Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include hashes in requirements.txt #261

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

include hashes in requirements.txt #261

wants to merge 2 commits into from
+496 −50

Conversation

HumairAK
Copy link
Contributor

Description

include hashes in requirements.txt

How Has This Been Tested?

running a test b uild

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@HumairAK
include hashes in requirements.txt
c5c2fcb 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Copy link
Contributor Author

cc @moulalis

@HumairAK
add requirements-build
21db614 
note that this requires additional documentation and ci to build out,
but because kfp-pipeline-spec only includes wheel files and not src,
internal build systems are having issues buildling this file out. A more
maintainable long term solution will be needed, one solution is to
separate the kfp-pipeline-spec into a separate requirements-wheels.txt file
Or simply have the maintainers update the package to also include source
files.

we also include a requirements-build.txt file for providing support
for cachito builds, and work around lack of sdist in the kfp-pipeline-spec
package.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HumairAK