Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install olot, skopeo, and model-registry in the generic runtime image #270

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Install olot, skopeo, and model-registry in the generic runtime image #270

merged 2 commits into from
Feb 27, 2025

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Feb 18, 2025

Description

This will be required for building the Modelcar image in a future PR.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@mprahl mprahl requested a review from HumairAK February 18, 2025 16:36
@mprahl
Install olot and skopeo in the generic runtime image
4a00173 
This will be required for building the Modelcar image in a future PR.

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
@mprahl mprahl mentioned this pull request Feb 27, 2025
Open
3 tasks
@mprahl mprahl changed the title Install olot and skopeo in the generic runtime image Install olot, skopeo, and model-registry in the generic runtime image Feb 27, 2025
@mprahl
Copy link
Contributor Author

mprahl commented Feb 27, 2025

/cc @rimolive @gmfrasca

rimolive
rimolive reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@rimolive rimolive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Thanks @mprahl

dandawg
dandawg reviewed Feb 27, 2025
View reviewed changes
Copy link

@dandawg dandawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mprahl
Install the model-registry Python package in the generic runtime image
a04116e 
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
@mprahl mprahl requested review from rimolive and dandawg February 27, 2025 20:45
@HumairAK
Copy link
Contributor

/lgtm
/approve

@HumairAK HumairAK merged commit c930555 into opendatahub-io:main Feb 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HumairAK HumairAK Awaiting requested review from HumairAK

@rimolive rimolive Awaiting requested review from rimolive

@dandawg dandawg Awaiting requested review from dandawg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mprahl @HumairAK @rimolive @dandawg