add new input parameters #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
reviewed
Feb 25, 2025
mprahl
reviewed
Feb 25, 2025
HumairAK
force-pushed
the
add_parameters
branch
from
13d1d88 to
eee0268
Compare
mprahl
approved these changes
Feb 25, 2025
|
these look good to me. |
mprahl
reviewed
Feb 25, 2025
gmfrasca
reviewed
Feb 25, 2025
the following inputs were added: * sdg/eval secrets * model registration inputs * input/output model info * hardware inputs for training/eval * renaming node/nproc variables to be easier to understand these inputs don't do anything yet, functionality soon to follow. Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
HumairAK
force-pushed
the
add_parameters
branch
from
eee0268 to
b0a8c1a
Compare
mprahl
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add inputs for v4 api: [1]
the following inputs were added:
these inputs don't do anything yet, functionality
soon to follow.
Merge criteria: