RHOAIENG-15772: tests(odh-nbc): wait for controller manager to stop before stopping envtest #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efore stopping envtest
Otherwise, there will be some errors printed in the output.
It was not breaking anything, but it was unpleasant to look at.
The notebook-controller does not seem to be suffering from this.
Probably because it does not use a webhook.
Example of the error message that's prevented by this
```
2024-11-17T20:19:57+01:00 ERROR controller-runtime.certwatcher error re-reading certificate {"error": "open /var/folders/f1/3m518k5d34l72v_9nqyjzqm80000gn/T/envtest-serving-certs-737480808/tls.crt: no such file or directory"}
```
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jiridanek
commented
Nov 17, 2024
| cfg *rest.Config | ||
| cli client.Client | ||
| envTest *envtest.Environment | ||
| cfg *rest.Config |
There was a problem hiding this comment.
The linter is right, but that's issue that has been in the repo for a long time already. See here for fix
|
/lgtm Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-15772
Relates to
Description
Otherwise, there will be some errors printed in the output. It was not breaking anything, but it was unpleasant to look at.
The notebook-controller does not seem to be suffering from this. Probably because it does not use a webhook.
Example of the error message that's prevented by this
How Has This Been Tested?
Merge criteria: