Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] Add feast operator component + Promethus config #1710

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Mar 5, 2025

Signed-off-by: Abdul Hameed ahameed@redhat.com
(cherry picked from commit 3fb2d67)

Description

sync #1705
#1498
#1608

https://issues.redhat.com/browse/RHOAIENG-19909
https://issues.redhat.com/browse/RHOAIENG-14792
https://issues.redhat.com/browse/RHOAIENG-19100

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

)

Signed-off-by: Abdul Hameed <ahameed@redhat.com>
(cherry picked from commit 3fb2d67)
@openshift-ci openshift-ci bot requested review from etirelli and robotmaxtron March 5, 2025 17:14
@zdtsw zdtsw requested review from CFSNM and redhatHameed and removed request for robotmaxtron and etirelli March 5, 2025 17:15
@openshift-ci openshift-ci bot added the lgtm label Mar 5, 2025
Copy link

openshift-ci bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CFSNM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 5, 2025
* feat: Add Feast Operator component

Signed-off-by: Abdul Hameed <ahameed@redhat.com>

* fix the PR review comments and rebase

Signed-off-by: Abdul Hameed <ahameed@redhat.com>

---------

Signed-off-by: Abdul Hameed <ahameed@redhat.com>
(cherry picked from commit 89b607a)
@openshift-ci openshift-ci bot removed the lgtm label Mar 5, 2025
Copy link

openshift-ci bot commented Mar 5, 2025

New changes are detected. LGTM label has been removed.

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 542b480)
@zdtsw zdtsw changed the title [sync] Added promethus config for feast operator component (#1705) [sync] Add feast operator component + Promethus config Mar 5, 2025
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 137 lines in your changes missing coverage. Please review.

Project coverage is 20.91%. Comparing base (e4f3b2b) to head (5334d79).
Report is 2 commits behind head on rhoai.

Files with missing lines Patch % Lines
...trollers/components/feastoperator/feastoperator.go 0.00% 65 Missing ⚠️
...mponents/feastoperator/feastoperator_controller.go 0.00% 38 Missing ⚠️
.../feastoperator/feastoperator_controller_actions.go 0.00% 22 Missing ⚠️
.../components/feastoperator/feastoperator_support.go 0.00% 6 Missing ⚠️
pkg/upgrade/upgrade.go 0.00% 3 Missing ⚠️
controllers/services/monitoring/monitoring.go 0.00% 2 Missing ⚠️
...atasciencecluster/datasciencecluster_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            rhoai    #1710      +/-   ##
==========================================
- Coverage   21.17%   20.91%   -0.26%     
==========================================
  Files         160      164       +4     
  Lines       11024    11161     +137     
==========================================
  Hits         2334     2334              
- Misses       8457     8594     +137     
  Partials      233      233              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zdtsw zdtsw merged commit 50117fd into opendatahub-io:rhoai Mar 7, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants