[sync] update: monitoring config (#1676)

[zdtsw]

• update: monitoring config

• we only create monitoring stack on Managed Cluster
• regardless DSCI set monitoring to Managed or not, Self and ODH wont create resource
• monitoring namespace are immutable, as it cannot be changed unless delete DSCI
• some small code refactor
• rename DSCMonitoring to DSCIMonitoring since it is close to DSCI
• regardless DSCI set monitoring to Removed or not, Managed will already have montioring on

Signed-off-by: Wen Zhou wenzhou@redhat.com

• update: review comments

• revert back to old flag name in case break any current users (should not be the case)
• remove unused parameter

Signed-off-by: Wen Zhou wenzhou@redhat.com

---

Signed-off-by: Wen Zhou wenzhou@redhat.com
(cherry picked from commit 2fa3afc)

Description

sync #1676

https://issues.redhat.com/browse/RHOAIENG-19988

How Has This Been Tested?

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ykaliuta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 20.98%. Comparing base (e4f3b2b) to head (7133f6c).
Report is 1 commits behind head on rhoai.

Files with missing lines	Patch %	Lines
.../dscinitialization/dscinitialization_controller.go	0.00%	20 Missing and 1 partial ⚠️
controllers/dscinitialization/utils.go	0.00%	4 Missing and 4 partials ⚠️
pkg/upgrade/upgrade.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            rhoai    #1711      +/-   ##
==========================================
- Coverage   21.17%   20.98%   -0.19%     
==========================================
  Files         160      160              
  Lines       11024    10999      -25     
==========================================
- Hits         2334     2308      -26     
- Misses       8457     8459       +2     
+ Partials      233      232       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.