Improve controller-runtime cache configuration #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove managed fields, as they are not used directly by the operator code - add Pods to the list of uncached objects as they may have an high cardinality - add Group to the list of uncached objects, since such objects are only created once
lburgazzoli
requested review from
grdryn and
zdtsw
and removed request for
robotmaxtron
zdtsw
approved these changes
Mar 7, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test opendatahub-operator-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
==========================================
+ Coverage 23.59% 23.60% +0.01%
==========================================
Files 171 171
Lines 11651 11646 -5
==========================================
Hits 2749 2749
+ Misses 8627 8622 -5
Partials 275 275 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lburgazzoli
added a commit
to lburgazzoli/opendatahub-operator
that referenced
this pull request
Mar 7, 2025
* feat: tune controller-runtime cache - remove managed fields, as they are not used directly by the operator code - add Pods to the list of uncached objects as they may have an high cardinality - add Group to the list of uncached objects, since such objects are only created once * chore: replace Group GET+CREATE with just CREATE (cherry picked from commit 6b2dcfc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Podsto the list of uncached objects because as today, we don't set any filter, hence we are caching all the Pods in a clusterGroupto the list of uncached objects, since such objects are only created onceGroupGET+CREATE with just CREATE since the objects are not more in the cacheHow Has This Been Tested?
Screenshot or short clip
This is not a very accurate analysis, but running a controller with the small optimization introduced by the PR (blue line), seems to report a constant reduction of the memory consumption of ~ 10 MB on pretty much empty cluster
NAME CPU(cores) MEMORY(bytes) opendatahub-operator-controller-manager-64c7594b46-9dccp 1m 173Mi NAME CPU(cores) MEMORY(bytes) opendatahub-operator-controller-manager-6c655dd69d-m7scs 1m 183MiMerge criteria
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).