Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment workflow #318

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

lydiascarf
Copy link
Collaborator

The Setup Ruby step was using an old version based on a deprecated runner image.

Merging this should resolve the issue Robert was seeing in this build in a recent PR.

The Setup Ruby step was using an old version based on a deprecated runner image.
@lydiascarf lydiascarf requested a review from rcheetham January 7, 2025 11:48
@lydiascarf lydiascarf self-assigned this Jan 7, 2025
@lydiascarf
Copy link
Collaborator Author

@BryanQuigley we could also not pin the version on that runner. it seems like we've manually updated it a couple times in the last year or two

Copy link
Member

@rcheetham rcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lydiascarf I like the idea you suggested of not pinning the version.

@rcheetham rcheetham merged commit e293dab into main Jan 7, 2025
5 checks passed
@rcheetham rcheetham deleted the 20240107-fix-deployment-workflow branch January 7, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants