Minor fixes #747
Open
Minor fixes #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks tests of tasks that do not need Nexus. Strictly speaking, Nexus is not needed at all for ODS Pipeline. It is only required when storing artifacts for later use (e.g. promotion).
docker inspect may also return image information, which is not desired.
While helpful in general, this breaks tests of tasks that do not use Bitbucket. Going forward we should find a way to require the Url but set it e.g. to https://example.com when tests do not require Bitbucket. For now, this is just a quick fix to unblock tests from upgrading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for more information.
Tasks:
docs/designdirectory or not applicabledocsdirectory or not applicablemake test) or not applicable