fix(nvmf/stuck): disconnect when target is in bad state #1947
+92
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was seen that sometimes the connection to the replica is in an odd state where adminq keeps failing to send the keep alive, and the nexus subsystem pause is hung. The theory is that there are stuck IOs somehow. Prior to 2.11 the timing out of replica IOs was not always correct so this could somehow be playing a part here. To attempt to unstuck the hang, we now wait up to the adminq keep alive timeout and then in case the nexus is pausing we now force disconnect the bad replica. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
auto-assign
bot
requested review from
Abhinandan-Purkait and
abhilashshetty04
Abhinandan-Purkait
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was seen that sometimes the connection to the replica is in an odd state where adminq keeps failing to send the keep alive, and the nexus subsystem pause is hung.
The theory is that there are stuck IOs somehow. Prior to 2.11 the timing out of replica IOs was not always correct so this could somehow be playing a part here.
To attempt to unstuck the hang, we now wait up to the adminq keep alive timeout and then in case the nexus is pausing we now force disconnect the bad replica.