Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Chart - Check prometheus CRD availability before creating ServiceMonitor - PodMonitor - PrometheusRule resources #107

Closed
cmontemuino opened this issue Jan 16, 2024 · 3 comments
Closed

Helm Chart - Check prometheus CRD availability before creating ServiceMonitor - PodMonitor - PrometheusRule resources #107

cmontemuino opened this issue Jan 16, 2024 · 3 comments

Comments

@cmontemuino
Copy link
Contributor

Given that the prometheus-stack dependency can be disabled (see condition: kube-prometheus-stack.install), adding a couple of guardrails to prometheus resources might make sense:

  • templates/podmonitors.yaml
  • templates/prometheusRules.yaml
  • templates/servicemonitors.yaml
@cmontemuino
Copy link
Contributor Author

I can open a PR if that helps.

@datacore-vvarakantham
Copy link
Contributor

Sure, please proceed to open a PR.

cmontemuino added a commit to cmontemuino/monitoring that referenced this issue Jan 29, 2024
@cmontemuino
chore(chart): check CRDs available before installing prometheus resou…
06a76b7 
…rces

Prometheus  resources should not be rendered unless Prometheus CRDs are
available.

This changeset includes an extra option to override the `apiVersion` Prometheus
provides.

close openebs#107

Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
@cmontemuino cmontemuino mentioned this issue Jan 29, 2024
Closed
@cmontemuino
Copy link
Contributor Author

Hi @datacore-vvarakantham, I've just opened an PR to address this issue: #108

cmontemuino added a commit to cmontemuino/monitoring that referenced this issue Sep 16, 2024
@cmontemuino
chore(chart): check CRDs available before installing prometheus resou…
7d5c116 
…rces

Prometheus  resources should not be rendered unless Prometheus CRDs are
available.

This changeset includes an extra option to override the `apiVersion` Prometheus
provides.

close openebs#107

Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
abhilashshetty04 pushed a commit that referenced this issue Sep 16, 2024
@cmontemuino @abhilashshetty04
chore(chart): check CRDs available before installing prometheus resou…
f18f68c 
…rces

Prometheus  resources should not be rendered unless Prometheus CRDs are
available.

This changeset includes an extra option to override the `apiVersion` Prometheus
provides.

close #107

Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
abhilashshetty04 pushed a commit that referenced this issue Sep 18, 2024
@cmontemuino @abhilashshetty04
chore(chart): check CRDs available before installing prometheus resou…
c093d16 
…rces

Prometheus  resources should not be rendered unless Prometheus CRDs are
available.

This changeset includes an extra option to override the `apiVersion` Prometheus
provides.

close #107

Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(chart): check CRDs available before installing prometheus resources cmontemuino/monitoring
2 participants
@cmontemuino @datacore-vvarakantham