chore(chart): check CRDs available before installing prometheus resources #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a conflict that needs resolution. |
|
Hi @cmontemuino , Thanks for thr PR. Can you please remove chart bump from your commit. We will cherry-pick your commit on PR which will have chart bump. |
…rces Prometheus resources should not be rendered unless Prometheus CRDs are available. This changeset includes an extra option to override the `apiVersion` Prometheus provides. close openebs#107 Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
cmontemuino
force-pushed
the
check-prometheus-capabilities
branch
from
06a76b7 to
7d5c116
Compare
Hi @abhilashshetty04. I did a rebase against latest changes and kept file |
|
Changes from this PR have been cherry-picked in #119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus resources should not be rendered unless Prometheus CRDs are available.
This changeset includes an extra option to override the
apiVersionPrometheus provides.close #107