feat: upgraded to node v18, added .nvmrc and updated workflows

.eslintrc.json

@@ -1,4 +1,5 @@
 {
+    "root": true,
     "extends": "@edx/eslint-config",
     "plugins": [
         "import"

.github/scripts/testing-js.sh

@@ -1,9 +1,4 @@
-if [[ $NODE == 16 ]]
-then
-  export NODE_VERSION=16.14.0
-else
-  export NODE_VERSION=12.11.1
-fi
+export NODE_VERSION=18.15.0
 
 docker exec -t insights_testing bash -c "
     cd /edx/app/insights/edx_analytics_dashboard/ &&

.github/workflows/ci.yml

@@ -13,7 +13,6 @@ jobs:
         python-version: ["3.8"]
         os: [ubuntu-20.04]
         toxenv: [django42]
-        node: [16]
     env:
       DATA_API_VERSION: "latest"
     steps:
@@ -42,12 +41,17 @@ jobs:
           TESTNAME: quality
           TARGETS: "quality"
           TOXENV: ${{ matrix.toxenv }}
+
+      - name: Setup Nodejs
+        uses: actions/setup-node@v3
+        with:
+          node-version-file: '.nvmrc'
+
       - name: test js
         run: ./.github/scripts/testing-js.sh
         shell: bash
         env:
           TESTNAME: js
-          NODE: ${{ matrix.node }}
           TOXENV: ${{ matrix.toxenv }}
           TARGETS: "requirements.js validate_js"
       - name: test i18n
@@ -62,16 +66,14 @@ jobs:
         shell: bash
         env:
           TESTNAME: acceptance
-          NODE: ${{ matrix.node }}
           TOXENV: ${{ matrix.toxenv }}
           TARGETS: "requirements.a11y migrate requirements.js static accept"
       - name: test python
         run: ./.github/scripts/testing-js.sh
         shell: bash
         env:
           TESTNAME: test-python
-          NODE: ${{ matrix.node }}
           TOXENV: ${{ matrix.toxenv }}
           TARGETS: "requirements.js static test_python"
       - name: code cov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v3

.nvmrc

@@ -0,0 +1 @@
+18

Dockerfile

@@ -55,8 +55,8 @@ WORKDIR ${INSIGHTS_CODE_DIR}/
 # insights service config commands below
 RUN pip install  --no-cache-dir -r ${INSIGHTS_CODE_DIR}/requirements/production.txt 
 
-RUN nodeenv ${INSIGHTS_NODEENV_DIR} --node=16.14.0 --prebuilt \
-    && npm install -g npm@8.5.x
+RUN nodeenv ${INSIGHTS_NODEENV_DIR} --node=18.15.0 --prebuilt \
+    && npm install -g npm@9.5.x
 
 # Tried to cache the dependencies by copying related files after the npm install step but npm post install fails in that case.
 COPY . ${INSIGHTS_CODE_DIR}/

README.md

@@ -19,8 +19,8 @@ Prerequisites
 -------------
 * Python 3.8.x
 * [gettext](http://www.gnu.org/software/gettext/)
-* [node](https://nodejs.org) 12.11.1
-* [npm](https://www.npmjs.org/) 6.11.3
+* [node](https://nodejs.org) 18.x.x
+* [npm](https://www.npmjs.org/) 9.x.x
 
 Warning: You must have NPM version 5.5.1. Using another version might result in
 a different `package-lock.json` file. Committing those changes might break our

npm-post-install.sh

@@ -14,7 +14,7 @@ PATTERN_LIBRARY_LIB_PATH="${PATTERN_LIBRARY_SASS_PATH}/global"
 PATTERN_LIBRARY_LIBS=('bi-app-sass' 'bourbon' 'breakpoint-sass' 'susy')
 for lib in "${PATTERN_LIBRARY_LIBS[@]}"
 do
-    cp -rf ${NPM_PATH}/$lib $PATTERN_LIBRARY_LIB_PATH/
+  cp -rf ${NPM_PATH}/$lib $PATTERN_LIBRARY_LIB_PATH/
 done
 
 # pre-compile the pattern library to improve sass compilation performance