fix: code review points

openedx-unsupported · Oct 30, 2023 · 73768db · 73768db
1 parent 520ec81
commit 73768db
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/tests/android/tests/test_android_login.py b/tests/android/tests/test_android_login.py
@@ -160,11 +160,11 @@ def test_login_smoke(self, set_capabilities, setup_logging):
         setup_logging.info(f'Ending {TestAndroidLogin.__name__} Test Case')
         setup_logging.info('Ending {} Test Case'.format(TestAndroidLogin.__name__))
 
-    # def test_upgrade_app(self, set_capabilities, setup_logging):
-    #     """
-    #     Verifies that user can upgrade app
-    #     """
-
-    #     global_contents = Globals(setup_logging)
-    #     if global_contents.enable_workflows is False:
-    #         assert global_contents.upgrade_target_app(set_capabilities)
+    def test_upgrade_app(self, set_capabilities, setup_logging):
+        """
+        Verifies that user can upgrade app
+        """
+
+        global_contents = Globals(setup_logging)
+        if global_contents.enable_workflows is False:
+            assert global_contents.upgrade_target_app(set_capabilities)
diff --git a/tests/android/tests/test_android_my_courses_list.py b/tests/android/tests/test_android_my_courses_list.py
@@ -78,7 +78,6 @@ def test_validate_ui_elements_smoke(self, set_capabilities, setup_logging):
         learn_tab.click()
         assert learn_tab.get_attribute('selected') == strings.TRUE
 
-    # @pytest.mark.skip(reason="Not getting any element to scroll in landscape mode, will figure it out later")
     def test_landscape_smoke(self, set_capabilities, setup_logging):
         """
         Scenarios: