This repository has been archived by the owner on May 6, 2024. It is now read-only.
chore: update test cases with app nav design #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilalawan321
force-pushed
the
bilal/LEARNER-9542
branch
6 times, most recently
from
6d957a4 to
a48c03b
Compare
Fix failed test cases after releae 5.0.3 Update strings and android elements files for app nav designs
bilalawan321
force-pushed
the
bilal/LEARNER-9542
branch
from
a48c03b to
520ec81
Compare
moeez96
reviewed
Oct 30, 2023
| assert discussion_tab_element.get_attribute('selected') == 'true' | ||
| assert android_course_dashboard_page.course_dashboard_course_organization().text \ | ||
| == strings.LOGIN_EDX_LOGO | ||
| assert android_course_dashboard_page.course_dashboard_course_expiry_date().text |
There was a problem hiding this comment.
Can you please confirm what this assertion is doing?
There was a problem hiding this comment.
course_dashboard_course_expiry_date method returns the element that has the Course Ending date in it on the header of course dashboard page, and the assertion is expecting that element has valid text in it.
For reference, you can see the attached screenshot which has the text Ended on August 31
Comment on lines
163
to
166
| # def test_upgrade_app(self, set_capabilities, setup_logging): | ||
| # """ | ||
| # Verifies that user can upgrade app | ||
| # """ |
Comment on lines
168
to
170
| # global_contents = Globals(setup_logging) | ||
| # if global_contents.enable_workflows is False: | ||
| # assert global_contents.upgrade_target_app(set_capabilities) |
|
|
||
| @pytest.mark.skip(reason="Not getting any element to scroll in landscape mode, will figure it out later") | ||
| # @pytest.mark.skip(reason="Not getting any element to scroll in landscape mode, will figure it out later") |
moeez96
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEARNER-9542
Description
Automate the following screens for app nav design:
Remove Course and Video sub section screens after app nav
Update all screens after Android release 5.0.3