Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

chore: update ownership info for repo #418

Merged
merged 5 commits into from
Mar 13, 2024
Merged

chore: update ownership info for repo #418

merged 5 commits into from
Mar 13, 2024

Conversation

jristau1984
Copy link
Contributor

Continuing maintainership updates for 2U 2024.

@jristau1984 jristau1984 requested a review from a team as a code owner March 12, 2024 02:27
@jristau1984 jristau1984 requested a review from feanil March 12, 2024 02:27
@jristau1984
Copy link
Contributor Author

@navinkarkera pinging you on this PR, as there appeared to be several other locations that claim some form of ownership on the repo.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.14%. Comparing base (a5935cd) to head (7d4e178).

❗ Current head 7d4e178 differs from pull request most recent head 36c9ad5. Consider uploading reports for the commit 36c9ad5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   53.14%   53.14%           
=======================================
  Files          80       80           
  Lines        2021     2021           
  Branches      368      368           
=======================================
  Hits         1074     1074           
  Misses        914      914           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navinkarkera
Copy link
Contributor

@jristau1984 Thanks! Do you thinks it makes sense to add my name in these files as well?

cc: @feanil

@jristau1984
Copy link
Contributor Author

I tagged you instead of replacing our team with your name because I had that exact same question. I don't know what each and every one of these files is really supposed to do, so I think @feanil could offer better guidance.

Copy link
Contributor

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although it is ok that owner is not specified, per:

https://open-edx-proposals.readthedocs.io/en/latest/archived/oep-0002-bp-repo-metadata.html#id4

An empty space is not valid YAML, and this will fail reporting tools. Instead, please add '~' or 'null' or ''''.

openedx.yaml Outdated Show resolved Hide resolved
Co-authored-by: connorhaugh <49422820+connorhaugh@users.noreply.github.com>
@jristau1984 jristau1984 requested a review from connorhaugh March 12, 2024 13:35
@jristau1984 jristau1984 merged commit acb0911 into master Mar 13, 2024
5 checks passed
@jristau1984 jristau1984 deleted the ownership-update branch March 13, 2024 02:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants