fix: throws InvalidScopeError if the FieldData for the scope is None (#…

…815)

CHANGELOG.rst

@@ -5,6 +5,11 @@ Change history for XBlock
 Unreleased
 ----------
 
+5.1.2 - 2025-02-07
+------------------
+
+* throws InvalidScopeError if the scope is not defined
+
 5.1.0 - 2024-08-07
 ------------------
 

xblock/__init__.py

@@ -2,4 +2,4 @@
 XBlock Courseware Components
 """
 
-__version__ = '5.1.1'
+__version__ = '5.1.2'

xblock/field_data.py

@@ -145,10 +145,12 @@ def _field_data(self, block, name):
         """Return the field data for the field `name` on the :class:`~xblock.core.XBlock` `block`"""
         scope = block.fields[name].scope
 
-        if scope not in self._scope_mappings:
+        scope_mapping = self._scope_mappings.get(scope)
+
+        if scope_mapping is None:
             raise InvalidScopeError(scope)
 
-        return self._scope_mappings[scope]
+        return scope_mapping
 
     def get(self, block, name):
         return self._field_data(block, name).get(block, name)

xblock/test/test_field_data.py

@@ -40,6 +40,11 @@ def setup_method(self):
             Scope.content: self.content,
             Scope.settings: self.settings
         })
+        self.split_empty = SplitFieldData({
+            Scope.content: self.content,
+            Scope.settings: self.settings,
+            Scope.user_state: None,
+        })
         self.runtime = TestRuntime(services={'field-data': self.split})
         self.block = TestingBlock(
             runtime=self.runtime,
@@ -76,6 +81,10 @@ def test_invalid_scope(self):
         with pytest.raises(InvalidScopeError):
             self.split.get(self.block, 'user_state')
 
+    def test_empty_scope(self):
+        with pytest.raises(InvalidScopeError):
+            self.split_empty.get(self.block, 'user_state')
+
     def test_default(self):
         self.split.default(self.block, 'content')
         self.content.default.assert_called_once_with(self.block, 'content')