fix: editors fetching query for self paced courses in send_course_deadline_emails command #4640
Conversation
| @@ -97,7 +97,7 @@ def handle_send_email_to_pcs_and_editors(self, course, course_run, email_variant | |||
| This method retrieves the email addresses of course editors and project coordinators associated with the course | |||
| and schedules the email to be sent using the `process_send_course_deadline_email` task. | |||
| """ | |||
| course_editors = list(course.editors.values_list('user__email', flat=True).distinct()) | |||
| course_editors = list(course.draft_version.editors.values_list('user__email', flat=True).distinct()) | |||
There was a problem hiding this comment.
We can use Course.objects.filter_drafts(), as it has been used in editor API, to ensure that if a draft exists, return that. Otherwise, return non-draft.
There was a problem hiding this comment.
Course.objects.filter_drafts() basically returns a queryset of all draft courses. Are you referring to adding the uuid here to this queryset to fetch only specific course?
Or should we use it in the command’s handle method in filtering instead?
There was a problem hiding this comment.
Or should we use it in the command’s handle method in filtering instead?
this. This will do the required filtering at the very top and we would not need to add this draft_version handling here.
There was a problem hiding this comment.
If we update them here, we still need to access the official version below because the draft version of a course only has an associated draft run, which is not marketable
There was a problem hiding this comment.
Ah, right. Makes sense.
AfaqShuaib09
force-pushed
the
afaq/prod-4348-2
branch
2 times, most recently
from
db26df8 to
330b6f2
Compare
…dline_emails command (openedx#4640) * fix: editors fetching query for self paced courses in send_course_deadline_emails command * test: update unittests accordingly * fix: a test
This PR fixes the editors query to fetch them from the draft version of the course instead of the official version. While testing the send_course_deadline_emails command, I found that course editors are linked to the draft entry of the course, not the non-draft version.
I've verified email sending functionality by assigning manually course_editor to draft entry of course.