-
Notifications
You must be signed in to change notification settings - Fork 176
fix: replace headless property in browser options class #4642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Thanks for the pull request, @emmanuel-ferdman! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @emmanuel-ferdman - thank you for this contribution! Please let me know if you have any questions regarding submitting a CLA form. Thanks! |
@emmanuel-ferdman |
@mphilbrick211 I think it was signed. @e0d Updated, thanks for the review. |
@e0d anything else is needed from my side? 😃 |
@emmanuel-ferdman sorry for the delay, but was away for the Open edX conference. It looks like there are some quality errors. Can you have a look. I'm not sure what's causing the migration checks to fail, but will look when I have a moment. |
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
thanks @e0d! I accidentally pushed the wrong commit at first, but it should be all good now 😄 |
PR Summary
This small PR resolves the Selenium deprecation warnings coming from the headless property which you can find in the CI logs: