-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adaptive display of links for Quince #34433
base: open-release/quince.master
Are you sure you want to change the base?
feat: adaptive display of links for Quince #34433
Conversation
Do not display the 'Learn more' and 'Share feedback' links for banner that is enabled by the context_course.discussions_settings flag if the URLs for these links are not set in the settings.
Thanks for the pull request, @DmytroAlipov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hide Learn more and Share feedback links on the studio discussions info banner if the corresponding settings are empty. Should be dropped when upstream PR will be merged: - master openedx#34432, - quince openedx#34433. YT: - https://youtrack.raccoongang.com/issue/RGOeX-26488
"Course Number Display String" option doesn't influence certificate. YT: - https://youtrack.raccoongang.com/issue/RGOeX-26471 Should be dropped when upstream PR will be merged: - openedx#34432 - openedx#34433
@pdpinch are you able to review this (as you merged the master), or is this no longer needed? |
This is a backport from the master.
Description
Do not display the 'Learn more' and 'Share feedback' links for the banner that is enabled by the context_course.discussions_settings flag if the URLs for these links are not set in the settings.
DISCUSSIONS_INCONTEXT_LEARNMORE_URL
DISCUSSIONS_INCONTEXT_FEEDBACK_URL