Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adaptive display of links for Quince #34433

Open
wants to merge 1 commit into
base: open-release/quince.master
Choose a base branch
from

Conversation

DmytroAlipov
Copy link
Contributor

This is a backport from the master.

Description

Do not display the 'Learn more' and 'Share feedback' links for the banner that is enabled by the context_course.discussions_settings flag if the URLs for these links are not set in the settings.

  • DISCUSSIONS_INCONTEXT_LEARNMORE_URL
  • DISCUSSIONS_INCONTEXT_FEEDBACK_URL
screen_50

Do not display the 'Learn more' and 'Share feedback' links for
banner that is enabled by the context_course.discussions_settings
flag if the URLs for these links are not set in the settings.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 27, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 27, 2024

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Mar 27, 2024
dyudyunov pushed a commit to GSVlabs/philu-edx-platform that referenced this pull request Apr 18, 2024
Hide Learn more and Share feedback links on the studio
discussions info banner if the corresponding settings are empty.
Should be dropped when upstream PR will be merged:
- master openedx#34432,
- quince openedx#34433.
YT:
- https://youtrack.raccoongang.com/issue/RGOeX-26488
dyudyunov pushed a commit to GSVlabs/philu-edx-platform that referenced this pull request Apr 18, 2024
"Course Number Display String" option doesn't influence
certificate.

YT:
- https://youtrack.raccoongang.com/issue/RGOeX-26471

Should be dropped when upstream PR will be merged:
- openedx#34432
- openedx#34433
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label May 16, 2024
@mphilbrick211
Copy link

@pdpinch are you able to review this (as you merged the master), or is this no longer needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Status: Backlog
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants