Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OLD/ABANDONED] fix: add should_display_status_to_user method and status_changed field to VerificationAttempt model #35507

Closed
wants to merge 3 commits into from

Conversation

ilee2u
Copy link
Contributor

@ilee2u ilee2u commented Sep 19, 2024

Ticket: https://2u-internal.atlassian.net/browse/COSMO-499

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@ilee2u ilee2u changed the title fix: add placeholder should_display_status_to_user fix: add should_display_status_to_user method and status_changed field to VerificationAttempt model Sep 20, 2024
@ilee2u ilee2u closed this Sep 20, 2024
@ilee2u ilee2u deleted the ilee2u/temp-should-display-status-placeholder branch September 20, 2024 18:33
@ilee2u ilee2u changed the title fix: add should_display_status_to_user method and status_changed field to VerificationAttempt model [OLD] fix: add should_display_status_to_user method and status_changed field to VerificationAttempt model Sep 20, 2024
@ilee2u ilee2u changed the title [OLD] fix: add should_display_status_to_user method and status_changed field to VerificationAttempt model [OLD/ABANDONED] fix: add should_display_status_to_user method and status_changed field to VerificationAttempt model Sep 20, 2024
@ilee2u
Copy link
Contributor Author

ilee2u commented Sep 20, 2024

Abandoned this PR so I could rename the branch to something more accurate based on the ticket. New PR here: #35514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant