chore: Remove edx-token-utils dependency #36077
Open
+398
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rijuma
force-pushed
the
rijuma/remove-edx-token-utils-dep
branch
12 times, most recently
from
48ab9fa to
ef07615
Compare
rijuma
force-pushed
the
rijuma/remove-edx-token-utils-dep
branch
3 times, most recently
from
fe88592 to
89a4ba5
Compare
rijuma
force-pushed
the
rijuma/remove-edx-token-utils-dep
branch
from
b4ab13b to
1aef9c7
Compare
rijuma
force-pushed
the
rijuma/remove-edx-token-utils-dep
branch
from
5d183d0 to
c372f0c
Compare
feanil
requested changes
Jan 17, 2025
| @@ -2530,6 +2530,15 @@ | |||
| EXAMS_SERVICE_URL = 'http://localhost:18740/api/v1' | |||
| EXAMS_SERVICE_USERNAME = 'edx_exams_worker' | |||
|
|
|||
| ############## Settings for JWT token handling ############## | |||
| TOKEN_SIGNING = { | |||
There was a problem hiding this comment.
Did you add this here because the new tests you added are running in both the LMS and CMS environments? If so, I think that's not necessary and we can just run them in one of the two shards. So we could remove this and the block in cms/envs/test.py and then use the @skip_unless_lms decorator to skip these tests in the CMS context.
|
|
||
|
|
||
| ############## Settings for JWT token handling ############## | ||
| TOKEN_SIGNING = { |
There was a problem hiding this comment.
Are there docs for how to generate a valid TOKEN_SIGNING block that we could link to from here for people who are trying to setup their own instances?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's been a request to remove
edx-token-utilsdependency from the repository by Axim on issue #36009. The platform only uses one function from this repository, and since this repository is outdated one of the suggestions was to remove the dependency and fold the necessary parts intoedx-platformitself.This update moves the functionality for packing/unpacking and signing JWT tokens. We only use the unpacking on
edx-platformbut I thought it was a good idea to have both implementations just in case.This would have no noticeable impact user wise.
This is a 2U contribution, but I'd like to have a review from @openedx/committers-edx-platform if possible.
Supporting information
Testing instructions
Deadline
None.