fix: catch a possible exception in beta course configuration #36172
Conversation
when the learner is a beta tester, and the beta test has been set up with a large duration, the courseware djangoapp can return an overflow error on a timedelta call. In those circumstances, this defaults to returning an unmodified date. FIXES: APER-3848
removing an unused import
| @@ -93,7 +95,7 @@ def enterprise_learner_enrolled(request, user, course_key): | |||
| # enterprise_customer_data is either None (if learner is not linked to any customer) or a serialized | |||
| # EnterpriseCustomer representing the learner's active linked customer. | |||
| enterprise_customer_data = enterprise_customer_from_session_or_learner_data(request) | |||
| learner_portal_enabled = enterprise_customer_data and enterprise_customer_data['enable_learner_portal'] | |||
| learner_portal_enabled = enterprise_customer_data and enterprise_customer_data["enable_learner_portal"] | |||
There was a problem hiding this comment.
all of the changes in this file from this line down are just because I let my IDE autolint the file to our current standards. Usually I wouldn't commit an autoformat at the same time as an actual code change, but because the code change is just that one tiny block above, and the autoformat isn't extreme, it seemed like a legitimate choice. I can undo if reviewers prefer.
| adjusted_date = adjust_start_date(user, days_early_for_beta, start, course_key) | ||
| self.assertEqual(expected, adjusted_date) | ||
|
|
||
|
|
There was a problem hiding this comment.
same as above – from here on down it is just autoformatting. Again, I can undo it and just put in the individual changes the reviewers think it is too excessive.
deborahgu
deleted the
dkaplan1/APER-3848_improve-exception-handling-in-learner-home-init
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
when the learner is a beta tester, and the beta test has been set up with an extremely large duration, the courseware djangoapp can return an overflow error on a timedelta call. In those circumstances, this defaults to returning an unmodified date.
FIXES: APER-3848