Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Replace pkg_resources with importlib.resources in staging #36213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test Replace pkg_resources with importlib.resources in staging #36213

wants to merge 1 commit into from
+45 −61

Conversation

irtazaakram
Copy link
Member

Related to #36208

@irtazaakram irtazaakram added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Feb 4, 2025
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@irtazaakram
Copy link
Member Author

https://studio.pr-36213-139931.sandboxes.opencraft.hosting/static/studio/xblock/resources/drag_and_drop_v2/public/css/drag_and_drop.css

https://studio.pr-36213-139931.sandboxes.opencraft.hosting/static/studio/xblock/resources/drag_and_drop_v2/public/js/vendor/virtual-dom-1.3.0.min.js

https://studio.pr-36213-139931.sandboxes.opencraft.hosting/static/studio/xblock/resources/drag_and_drop_v2/public/js/drag_and_drop.js

These urls hit 404 in staging

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@irtazaakram irtazaakram force-pushed the test-pkg_resource-depr branch from 7062b89 to ec281fe Compare February 4, 2025 12:04
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@irtazaakram irtazaakram closed this Feb 4, 2025
@irtazaakram irtazaakram reopened this Feb 4, 2025
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@irtazaakram irtazaakram force-pushed the test-pkg_resource-depr branch from ec281fe to 15921f4 Compare February 6, 2025 06:48
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@feanil feanil mentioned this pull request Feb 6, 2025
Open
@irtazaakram irtazaakram marked this pull request as draft February 10, 2025 07:13
@irtazaakram irtazaakram removed the create-sandbox open-craft-grove should create a sandbox environment from this PR label Feb 10, 2025
@irtazaakram irtazaakram force-pushed the test-pkg_resource-depr branch from 15921f4 to d009067 Compare February 10, 2025 10:02
@irtazaakram irtazaakram added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Feb 10, 2025
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@irtazaakram irtazaakram force-pushed the test-pkg_resource-depr branch from 962116e to fad5e14 Compare February 10, 2025 14:01
@irtazaakram irtazaakram reopened this Feb 10, 2025
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@irtazaakram irtazaakram marked this pull request as ready for review February 10, 2025 14:49
@irtazaakram
Copy link
Member Author

Hi @schenedx, PR is ready for testing.

@irtazaakram irtazaakram requested a review from feanil February 10, 2025 14:51
feanil
feanil approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the Drag and Drop XBlock on the generated sandbox and saw that everything is working as expected in studio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irtazaakram @open-craft-grove @feanil