Skip to content

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Sep 13, 2024

Description

"No answer specified" confirmation window is displayed all the time after the second save for dropdown.

234

Steps to Reproduce:

  1. Add new Unit
  2. Add new component Problem
  3. Choose Dropdown
  4. Fill in at least question and answers (for the correct answer, enter the number)
  5. Click Save
  6. Click on Edit for problem again
  7. Click Save

@DmytroAlipov DmytroAlipov requested a review from a team as a code owner September 13, 2024 12:14
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 13, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 13, 2024

Thanks for the pull request, @DmytroAlipov!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.37%. Comparing base (06d591d) to head (d25a46d).
⚠️ Report is 346 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1278    +/-   ##
========================================
  Coverage   93.37%   93.37%            
========================================
  Files        1110     1110            
  Lines       22244    22244            
  Branches     4715     4815   +100     
========================================
  Hits        20770    20770            
+ Misses       1409     1402     -7     
- Partials       65       72     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DmytroAlipov DmytroAlipov force-pushed the fix-confirmation-window branch 2 times, most recently from 88a90c5 to 6401af3 Compare September 13, 2024 15:42
@DmytroAlipov DmytroAlipov added the bug Report of or fix for something that isn't working as intended label Sep 13, 2024
@DmytroAlipov
Copy link
Contributor Author

@mphilbrick211 friendly ping

@mphilbrick211
Copy link

Hi @openedx/2u-tnl flagging this - thanks!

@DmytroAlipov DmytroAlipov force-pushed the fix-confirmation-window branch from 6401af3 to e330941 Compare November 5, 2024 07:28
@mphilbrick211
Copy link

Hi @openedx/2u-tnl - would someone be able to please review this? Thanks!

@mphilbrick211
Copy link

Hi @openedx/2u-tnl - would someone be able to please review this? Thanks!

Flagging this, @openedx/2u-tnl

@mfarhan943
Copy link
Contributor

@DmytroAlipov , this PR has conflicts. Kindly resolve them.

"No answer specified" confirmation window is displayed all the
time after second save for dropdown.
@DmytroAlipov DmytroAlipov force-pushed the fix-confirmation-window branch from e330941 to d25a46d Compare March 2, 2025 17:32
@DmytroAlipov
Copy link
Contributor Author

@mfarhan943 done

@mfarhan943
Copy link
Contributor

@DmytroAlipov It's breaking when save an empty correct answer, then edit and save the same values again.

@mphilbrick211 mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Mar 3, 2025
Arpit-Nakrani-Networked pushed a commit to Arpit-Nakrani-Networked/frontend-app-authoring that referenced this pull request Jul 13, 2025
@cmltaWt0
Copy link
Contributor

cmltaWt0 commented Sep 7, 2025

Closed in favor of #2429

@cmltaWt0 cmltaWt0 closed this Sep 7, 2025
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants