-
Notifications
You must be signed in to change notification settings - Fork 160
fix: confirmation window is displayed after save for dropdown #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, @DmytroAlipov! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1278 +/- ##
========================================
Coverage 93.37% 93.37%
========================================
Files 1110 1110
Lines 22244 22244
Branches 4715 4815 +100
========================================
Hits 20770 20770
+ Misses 1409 1402 -7
- Partials 65 72 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
88a90c5
to
6401af3
Compare
@mphilbrick211 friendly ping |
Hi @openedx/2u-tnl flagging this - thanks! |
6401af3
to
e330941
Compare
Hi @openedx/2u-tnl - would someone be able to please review this? Thanks! |
Flagging this, @openedx/2u-tnl |
@DmytroAlipov , this PR has conflicts. Kindly resolve them. |
"No answer specified" confirmation window is displayed all the time after second save for dropdown.
e330941
to
d25a46d
Compare
@mfarhan943 done |
@DmytroAlipov It's breaking when save an empty correct answer, then edit and save the same values again. |
Closed in favor of #2429 |
Description
"No answer specified" confirmation window is displayed all the time after the second save for dropdown.
Steps to Reproduce:
Unit
Problem
Dropdown
Save
Edit
for problem againSave