-
Notifications
You must be signed in to change notification settings - Fork 160
fix: answer range format validation and error message in Numerical input #2426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: answer range format validation and error message in Numerical input #2426
Conversation
Thanks for the pull request, @ihor-romaniuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2426 +/- ##
==========================================
+ Coverage 94.63% 94.65% +0.02%
==========================================
Files 1180 1180
Lines 26151 26164 +13
Branches 5836 5824 -12
==========================================
+ Hits 24747 24766 +19
+ Misses 1333 1327 -6
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
} | ||
if (rawUpperBound.includes('/')) { | ||
if (!rawUpperBound) { | ||
upperBoundInt = lowerBoundInt; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport Pull Requests to frontend-lib-content-components: openedx-unsupported/frontend-lib-content-components#511
Description
These fixes validate input range format; it accepts the following response forms:
[1,10]
,[1, 10]
,[ 1,10 ]
,[ 1, 10 ]
,[1, 10 ]
,[ 1, 10]
,[1.1,10]
,[1.1,10.1]
,[1.1,10.1]
and display error on incorrect format like:[1.10]
,[1;10]
,[1/10]
, etc.Steps to reproduce
Actual result
Nothing happened, in console there's error

Note: the same when user print additional bracket
Expected result
Some validation should be for field or some error message for user should be shown


Before save:
After save:
Note
Old closed MR #1557