fix: Rename field should use full available width #2337 #2436
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2436 +/- ##
========================================
Coverage 94.71% 94.71%
========================================
Files 1202 1202
Lines 26845 26845
Branches 6025 5874 -151
========================================
Hits 25425 25425
- Misses 1350 1361 +11
+ Partials 70 59 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| .inplace-text-editor-with-edit-input:focus-within { | ||
| &.inplace-text-editor-with-edit-input { |
There was a problem hiding this comment.
Is anything missing on the body of this selector or should it be removed?
There was a problem hiding this comment.
The empty &.inplace-text-editor-with-edit-input is a self-referential placeholder. It doesn’t change the compiled CSS but clarifies that styles inside apply only to the element itself when it’s focused, not its children. It’s often used for readability, maintainability, or to satisfy strict linters, even though it looks redundant.
There was a problem hiding this comment.
If it's not changing the compiled CSS, please just use a comment. The empty rule is confusing.
|
@bradenmacdonald can you please review this PR? |
|
@ahtesham-quraish Please address @jacobo-dominguez-wgu's review and then I can give it a quick second look and merge it. |
ahtesham-quraish
force-pushed
the
ahtesham/#2337
branch
from
ce66e7a to
cae29f7
Compare
I have removed it you can check now. |
ahtesham-quraish
force-pushed
the
ahtesham/#2337
branch
from
cae29f7 to
1c2634e
Compare
There was a problem hiding this comment.
Looks good! @ahtesham-quraish can you please rebase this PR so the tests are passing, and then I'll merge it? Sorry for the delay here.
fix: merge with master
3 participants
Description
Rename field should use full available width #2337
After Changes