Skip to content

Conversation

vladislavkeblysh
Copy link
Contributor

@vladislavkeblysh vladislavkeblysh commented Sep 22, 2025

  • Fixed delete for additional video url fields
    280526648-fa3f9aa5-7710-4662-8a95-4d5674eae4a6

Moved from openedx-unsupported/frontend-lib-content-components#418

sumac - #2471

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 22, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @vladislavkeblysh!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@vladislavkeblysh vladislavkeblysh self-assigned this Sep 22, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Sep 22, 2025
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/delete-button-master branch from 854b28c to 327792c Compare September 22, 2025 06:31
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/delete-button-master branch from 6be0766 to 77ed57c Compare September 22, 2025 07:14
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.64%. Comparing base (1efa94d) to head (64c3cc7).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2470      +/-   ##
==========================================
- Coverage   94.65%   94.64%   -0.01%     
==========================================
  Files        1188     1188              
  Lines       26273    26236      -37     
  Branches     5835     5835              
==========================================
- Hits        24868    24831      -37     
  Misses       1335     1335              
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Sep 23, 2025
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this needs a few tweaks before it's ready to merge though:

</div>
{fallbackVideos.formValue.length > 0 ? fallbackVideos.formValue.map((videoUrl, index) => (
<Form.Row className="mt-3.5 mx-0 flex-nowrap">
<Form.Row className="mt-3.5 mx-0 flex-nowrap" key={videoUrl}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need something like the following:

Suggested change
<Form.Row className="mt-3.5 mx-0 flex-nowrap" key={videoUrl}>
// eslint-disable-next-line react/no-array-index-key
<Form.Row className="mt-3.5 mx-0 flex-nowrap" key={`${index}-${videoUrl}`}>

Because otherwise there's a very weird bug when the URLs are empty or the same:

Weird.Bug.mov

@bradenmacdonald
Copy link
Contributor

Thanks! Please just make that last change ^ and then I'll merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants