-
Notifications
You must be signed in to change notification settings - Fork 161
feat: Fixed delete for additional video url fields #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Fixed delete for additional video url fields #2470
Conversation
Thanks for the pull request, @vladislavkeblysh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
854b28c
to
327792c
Compare
6be0766
to
77ed57c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2470 +/- ##
==========================================
- Coverage 94.65% 94.64% -0.01%
==========================================
Files 1188 1188
Lines 26273 26236 -37
Branches 5835 5835
==========================================
- Hits 24868 24831 -37
Misses 1335 1335
Partials 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this needs a few tweaks before it's ready to merge though:
.../containers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/hooks.jsx
Outdated
Show resolved
Hide resolved
.../containers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/index.jsx
Outdated
Show resolved
Hide resolved
.../containers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/index.jsx
Show resolved
Hide resolved
</div> | ||
{fallbackVideos.formValue.length > 0 ? fallbackVideos.formValue.map((videoUrl, index) => ( | ||
<Form.Row className="mt-3.5 mx-0 flex-nowrap"> | ||
<Form.Row className="mt-3.5 mx-0 flex-nowrap" key={videoUrl}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need something like the following:
<Form.Row className="mt-3.5 mx-0 flex-nowrap" key={videoUrl}> | |
// eslint-disable-next-line react/no-array-index-key | |
<Form.Row className="mt-3.5 mx-0 flex-nowrap" key={`${index}-${videoUrl}`}> |
Because otherwise there's a very weird bug when the URLs are empty or the same:
Weird.Bug.mov
Thanks! Please just make that last change ^ and then I'll merge this. |
Moved from openedx-unsupported/frontend-lib-content-components#418
sumac - #2471