Skip to content

Conversation

Anas12091101
Copy link
Contributor

@Anas12091101 Anas12091101 commented Sep 29, 2025

Description

This PR introduces a new visibility option for assignment scores:

“Never show individual assessment results, but show overall assessment results after the due date.”

With this option, learners cannot see question-level correctness or scores at any time. However, once the due date has passed, they can view their overall score in the total grades section on the Progress page.

This PR should be reviewed in correspondence with openedx/frontend-app-learning#1797

Useful information to include:

  • Which user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
Screenshot 2025-10-02 at 12 39 45 PM

Supporting information

Proposal: https://openedx.atlassian.net/wiki/spaces/OEPM/pages/5150769174/Proposal+Add+option+to+show+overall+assessment+results+after+due+date+but+hide+individual+assessment+results
Internal ticket: https://github.com/mitodl/hq/issues/3859

Testing instructions

Included in openedx/frontend-app-learning#1797

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 29, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 29, 2025

Thanks for the pull request, @Anas12091101!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Sep 29, 2025
@Anas12091101 Anas12091101 marked this pull request as draft September 29, 2025 18:28
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Sep 29, 2025
@Anas12091101 Anas12091101 changed the title Anas/add new grade visisbility option feat: add never_but_include_grade visibility option Sep 30, 2025
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.68%. Comparing base (8fe5fb6) to head (8adc1b7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2489   +/-   ##
=======================================
  Coverage   94.68%   94.68%           
=======================================
  Files        1203     1203           
  Lines       26865    26865           
  Branches     6026     6027    +1     
=======================================
  Hits        25438    25438           
- Misses       1357     1368   +11     
+ Partials       70       59   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdpinch
Copy link

pdpinch commented Oct 1, 2025

@Anas12091101 can you check off the boxes in the PR description?

@pdpinch
Copy link

pdpinch commented Oct 1, 2025

In the description, you wrote, “Never show individual assessment results, but show overall assessment results after the due date” but the UI doesn't mention the due date. Is the description wrong, or do we need to change the text of the UI to mention the due date?

@Anas12091101
Copy link
Contributor Author

In the description, you wrote, “Never show individual assessment results, but show overall assessment results after the due date” but the UI doesn't mention the due date. Is the description wrong, or do we need to change the text of the UI to mention the due date?

Thanks for catching this. I had intended to copy the description from the proposal but must have mistakenly used an AI-generated version instead. I’ve now updated the PR with the correct title and description for the new option, as well as an updated screenshot.

@Anas12091101 Anas12091101 force-pushed the anas/add-new-grade-visisbility-option branch from ce42fc6 to 8adc1b7 Compare October 7, 2025 10:32
Copy link
Contributor

@asadali145 asadali145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants