Skip to content

Conversation

@asadali145
Copy link
Contributor

Description

This PR fixes the below issues:

  • When a block is changed, it reloads whole page to enable the publish button. This PR fixes it to only reload the sidebar to enable the publish button.

BEFORE:

Screen.Recording.2025-11-04.at.12.51.08.PM.mov

AFTER:

Screen.Recording.2025-11-04.at.1.08.12.PM.mov
  • If there are multiple tabs open, changing a block was reloading all tabs. This PR fixes it to reload the sidebar of only the current tab.

BEFORE:

Screen.Recording.2025-11-04.at.12.52.09.PM.mov

AFTER:

Screen.Recording.2025-11-04.at.1.08.52.PM.mov
  • Video block save does not enable the Publish button when updated; This PR fixes that as well.

BEFORE:

Screen.Recording.2025-11-04.at.12.53.57.PM.mov

AFTER:

Screen.Recording.2025-11-04.at.1.09.31.PM.mov

Testing instructions

  • Checkout master branch
  • Create a course and edit any problem block in a unit. Notice that the full page will reload and enable the publish button.
  • Now open another course in a new tab.
  • Open the problem editor and make changes in both tabs, Keep the unsaved changes open in the editor in one of the tabs and save the other one. Notice that both tabs will reload and you lose the changes in the tab with unsaved changes.
  • Now edit any video block and notice that the publish button won't be enabled and you have to reload the page to enable the publish button.
  • Checkout this branch and test all cases.

@openedx-webhooks
Copy link

Thanks for the pull request, @asadali145!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 4, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.82%. Comparing base (436ac31) to head (d815217).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2600    +/-   ##
========================================
  Coverage   94.82%   94.82%            
========================================
  Files        1226     1226            
  Lines       27557    27557            
  Branches     6043     6209   +166     
========================================
  Hits        26131    26131            
+ Misses       1368     1355    -13     
- Partials       58       71    +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asadali145 asadali145 requested a review from Faraz32123 November 4, 2025 08:27
@asadali145 asadali145 moved this from Needs Triage to Ready for Review in Contributions Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

2 participants