fix: do not publish APP_READY or APP_INIT_ERROR when failing to ensur…

…e authentication (#33)
openedx · Dec 5, 2019 · 3641eba · 3641eba
1 parent f98aa4f
commit 3641eba
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/src/auth/index.js b/src/auth/index.js
@@ -143,6 +143,10 @@ export const ensureAuthenticatedUser = async (redirectUrl = config.appBaseUrl) =
 
     // The user is not authenticated, send them to the login page.
     redirectToLogin(redirectUrl);
+
+    const unauthorizedError = new Error('Failed to ensure the user is authenticated');
+    unauthorizedError.isRedirecting = true;
+    throw unauthorizedError;
   }
 
   return getAuthenticatedUser();

diff --git a/src/auth/tests/AuthenticatedHttpClient.test.jsx b/src/auth/tests/AuthenticatedHttpClient.test.jsx
@@ -711,8 +711,9 @@ describe('ensureAuthenticatedUser', () => {
 
     it('attempts to refresh a missing jwt token and redirects user to login', () => {
       setJwtCookieTo(null);
-      return ensureAuthenticatedUser(`${process.env.BASE_URL}/route`).then((authenticatedUserAccessToken) => {
-        expect(authenticatedUserAccessToken).toBeNull();
+      expect.hasAssertions();
+      return ensureAuthenticatedUser(`${process.env.BASE_URL}/route`).catch((unauthorizedError) => {
+        expect(unauthorizedError.isRedirecting).toBe(true);
         expectSingleCallToJwtTokenRefresh();
         expectLogin(`${process.env.BASE_URL}/route`);
       });

diff --git a/src/initialize.js b/src/initialize.js
@@ -127,8 +127,10 @@ export async function initialize({
     await handlers.ready();
     publish(APP_READY);
   } catch (error) {
-    // Initialization Error
-    await handlers.initError(error);
-    publish(APP_INIT_ERROR, error);
+    if (!error.isRedirecting) {
+      // Initialization Error
+      await handlers.initError(error);
+      publish(APP_INIT_ERROR, error);
+    }
   }
 }