chore: removed Dockerfile, updated docker configuration files #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
previously requested changes
Nov 5, 2024
docker-compose.yml
Outdated
| build: | ||
| context: . | ||
| dockerfile: Dockerfile | ||
| image: edxops/license-manager-dev.worker |
There was a problem hiding this comment.
Previously, the image was being pushed with both tags but now we only have one image so we can use the same image in all steps i.e. edxops/license-manager-dev.
iloveagent57
force-pushed
the
bilalqamar95/dockerfile-setup-removal
branch
2 times, most recently
from
8ec0851 to
308fd1c
Compare
update docker-compose to pull from edxops repo
iloveagent57
force-pushed
the
bilalqamar95/dockerfile-setup-removal
branch
from
308fd1c to
5691e5f
Compare
iloveagent57
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #736
Description
This PR removes the local Dockerfile and updates all configurations to use the pre-built edxops/license-manager Docker image