Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to main v2.1 #566

Merged
merged 17 commits into from
Feb 11, 2025
Merged

Develop to main v2.1 #566

merged 17 commits into from
Feb 11, 2025

Conversation

volodymyr-chekyrta
Copy link
Contributor

Sync develop to the main branch.

Features:

  • Password Field: Added an eye icon to toggle password visibility.
  • Media & Playback: Implemented saving of video playback speed and improved YouTube handling (e.g., full-screen support on iPad).
  • Social Auth: Introduced banners for linked social accounts and enhanced sign-in/register flows.
  • CI/CD & Analytics: Set up linting on CI/CD and added push notification analytics.

Fixes:

  • Logout & Cookies: Ensured cookies are cleared on logout.
  • UI Issues: Fixed layout padding, tab bar colors, grid spacing, and Elm theme inconsistencies.
  • Swift 6 Migration: Addressed several issues related to the Swift 6 migration (e.g., JavaScript evaluation and download cancelation bugs).
  • Gestures & Logins: Resolved iOS 18 tap gesture issues and fixed the Microsoft login problem.

Refactors & Chores:

  • Project Migration: Migrated the project to Swift 6 with associated refactors.
  • Download Manager: Integrated and refactored the DownloadManager, fixing various download-related issues.
  • General Cleanup: Performed code cleanup, dependency updates, test fixes, and regular upstream synchronizations.

rnr and others added 16 commits November 18, 2024 19:19
* Merge pull request #42 from edx/password-input-view-eye

feat: eye icon for password field

* chore: added SecureInputView to project

* Merge pull request #44 from edx/clear-cookies-by-logout

fix: clear cookies by logout

* Merge pull request #47 from edx/reduce-grid-spacing

style: reduce grid spacing

* chore: Fix outdated course dates alert title truncation issue (#53)

* Merge pull request #57 from edx/remaining-size-in-gb-or-mb

chore: size in GB or MB

* fix: Remove urls from headings of End User lisence agreements (#65)

* fix: move padding to right place

* chore: fixed double space

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
Co-authored-by: Shafqat Muneer <smuneer@2u.com>
Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
* refactor: migrate project to swift 6

* fix: remove task in do after

* fix: address feedback

* fix: address feedback

* fix: update pods

* fix: update task priority

* fix: swift 6 bug with evaluate java script method

* fix: update models and fix video downloading canceling

* fix: address feedback
* fix: fixed script execution after commenting fullstory

* chore: added missed quote

* chore: edit regex since dev team could be set as empty in project file

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
* fix: video tab with youtube (#52)

* fix: don't show error if only youtube videos

* fix: call UI updates from main queue

* fix: don't send completion at youtube video start

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>

* chore: delete unneeded MainActor instructions

* feat: save playback speed (#67)

* chore: save playback speed in CourseStorage

* chore: add full screen for youtube on iPad

* chore: save value in userdefaults

* chore: little refactor

* fix: fix warning

* chore: added CourseStorage as injection

* chore: moved playback speed to user settings

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>

* chore: analytics screen events improvements and name fixes (#76)

* chore: fix tests

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
Co-authored-by: Saeed Bashir <sbashir@2u.com>
* fix: resolve lint warnings

* fix: resolve warnings and update swiftlint.yml

* fix: update swiftlint

* fix: update swiftlint

* fix: test lint warning

* Revert "fix: test lint warning"

This reverts commit e3c1566.

* fix: update tests

* fix: update swiftlint

* fix: address feedback

* fix: address feedback
* feat: banner when register with already linked social account (#54)

* fix: fix lint warnings

* chore: added banner when register with already linked social account

* style: changed text color

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>

* chore: fix after merge

* chore: update tab bar icons for selected unselected states (#81)

* chore: Elm theme improvements on Profile (#82)

* chore: fix after merge

* fix: fix tab bar color not properly applying (#85)

* fix: fix tar bar color not properly applying
* chore: parity with android for discover icon

* chore: added missed colors

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
Co-authored-by: Saeed Bashir <sbashir@2u.com>
Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
* chore: added alpha for color to whitelabel (#87)

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>

* chore: Elm theme improvements on Learn Tab (#88)

* chore: Elm theme improvement on course home (#86)

* chore: fix line length warning

* chore: Elm theme improvement on Course Discussions (#90)

* fix: fix after merge

* chore: Elm theme improvements for modals and alerts (#91)

* chore: fix after merge

* chore: configureable resume button (#92)

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
Co-authored-by: Saeed Bashir <sbashir@2u.com>
* chore: add video and discussion analytics (#93)

* fix: fixes after merge, deleted IAP parts

* chore: changed dependency version, deleted unused analytics part

* chore: regenerate mocks

* chore: In app ratings modal and profile picture picture sheet UI improvements (#94)

* chore: show subtitles for videos in full-screen mode (#97)

* fix: after merge

* fix: iOS 18 Toggle tap gesture (#98)

* fix: added priority for toggle tap gesture

* fix: fixed tap and drag actions for Toggle

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>

* fix: gesture for ios 18.2

* chore: quick fix with performance for subtitles view

---------

Co-authored-by: Saeed Bashir <sbashir@2u.com>
Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
Co-authored-by: Shafqat Muneer <smuneer@2u.com>
* chore: add video and discussion analytics (#93)

* fix: fixes after merge, deleted IAP parts

* chore: changed dependency version, deleted unused analytics part

* chore: regenerate mocks

* chore: In app ratings modal and profile picture picture sheet UI improvements (#94)

* chore: show subtitles for videos in full-screen mode (#97)

* fix: after merge

* fix: iOS 18 Toggle tap gesture (#98)

* fix: added priority for toggle tap gesture

* fix: fixed tap and drag actions for Toggle

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>

* fix: gesture for ios 18.2

* chore: quick fix with performance for subtitles view

* chore: sign-in and register screens social sign in improvements (#95)

* chore: fix after merge

* fix: fix microsoft login issue on iOS after config branch merges (#96)

* refactor: change the microsoft key name in the script (#101)

* chore: fix access modifier

* chore: re-generate nocks

* chore: hide grades when sub section dependents not available (#99)

* chore: fix after merge

* chore: hide progress points from assignment status (#100)

* chore: fix test

---------

Co-authored-by: Saeed Bashir <sbashir@2u.com>
Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
Co-authored-by: Shafqat Muneer <smuneer@2u.com>
* fix: fix social auth banner

Co-Authored-By: Anton Yarmolenko <37253+rnr@users.noreply.github.com>

* fix: fixed test

* chore: address feedback

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
* chore: log push notification status (#102)

* chore: fixes after merge, fix for swift6

---------

Co-authored-by: Saeed Bashir <sbashir@2u.com>
Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
* chore: improve the logic of video stream priority (#89)

* chore: set hls as priority quality for .auto case

* fix: fix failed test

---------

Co-authored-by: Saeed Bashir <sbashir@2u.com>
Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
* refactor: migrate project to swift 6

* fix: remove task in do after

* fix: address feedback

* fix: address feedback

* fix: update pods

* fix: update task priority

* fix: download issues (#43)

* fix: batch updates

* chore: fix ui update from background

* fix: changed download queue

* chore: a little refactor

* fix: play pause - issue

* fix: subtitles view for big videos

* fix: download after internet off

* chore: revert back config file

* chore: fixed tests

* chore: review changes

* chore: changed analytic events

* fix: download of html

* chore: fixed tryDownloadAgain

* chore: merge issues

* chore: regenerate mocks

* chore: fix bug with downloading

* fix: download issue

* fix: download issue

* fix: swift 6 bug with evaluate java script method

* chore: merge swift6 branch

* chore: disable file length

* chore: fix tests

* chore: removed useless code

* chore: fix freezes during download

* fix: download states

* chore: fixed tests

* chore: merge conflicts

* chore: merge issues

* fix: some download bugs

* fix: for condition race

* fix: size in DownloadActionView

* chore: remove extra line

* chore: fix crash

* chore: tests fix

* chore: added tests for CourseDownloadHelperTests

* chore: added more tests

* chore: fix test

* chore: fix test

* chore: commit to re-run jobs

* chore: increased waiting time for test

* chore: test fix

* chore: trying to fix unit tests

* chore: removed multiple publisher tests

---------

Co-authored-by: IvanStepanok <ivan.stepanok@raccoongang.com>
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 10, 2025

Thanks for the pull request, @volodymyr-chekyrta!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 10, 2025
@volodymyr-chekyrta volodymyr-chekyrta marked this pull request as draft February 11, 2025 09:44
@volodymyr-chekyrta volodymyr-chekyrta marked this pull request as ready for review February 11, 2025 10:58
@volodymyr-chekyrta volodymyr-chekyrta merged commit ba5a6a9 into main Feb 11, 2025
10 of 11 checks passed
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@255e2b7). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #566   +/-   ##
=====================================
  Coverage        ?      0           
=====================================
  Files           ?      0           
  Lines           ?      0           
  Branches        ?      0           
=====================================
  Hits            ?      0           
  Misses          ?      0           
  Partials        ?      0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants