-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat!: Drop support for the legacy video upload page. #37582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fdd2b61 to
0e3689c
Compare
fb7625b to
d6dd652
Compare
d6dd652 to
58979c3
Compare
58979c3 to
a9724da
Compare
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
Wow, net -7000, nice 🔥 I didn't even realize there was a legacy video uploads page! Is it this? https://edx.readthedocs.io/projects/edx-partner-course-staff/en/latest/video/upload_video.html Regarding the
I remember us discussing in standup (and hinted in that thread) that someone could maybe work on a version of the MFE page which didn't include any of the edX-specific stuff, and exposed plugin slots which edX could plug their stuff into. But I don't know what that would look like and I'm not sure who would do it. I think our options for the purpose of the legacy studio removal are either |
You're saying keep the cleanup but leave the waffle flag in place so that the new MFE page remains off by default since it's actually useless for non edx.org operators at the moment? If we do that, we have to answer the question of what does the backend do when the waffle flag is set to false and there is no old page to display. I think this means we update the code to not provide links to the video page in this case and so we'll need to update other older templates to put conditional around those references. Does that sound right to you @kdmccormick ? |
Good question, the thing is I'm not actually sure how one gets to the legacy video page, up until now I didn't know it even existed. Do you know how it's accessed today? Is it possible it's already behind some flag? If the new uploads page is fully edX-specific, then I'd guess that the legacy page is edX-specific too. |
The legacy video uploads page in Studio has been replaced with a new view in the Authoring MFE. This change removes the now unused JS/CSS/HTML/Python related to the old video page. This work is part of #36108 BREAKING CHANGE: The `contentstore.new_studio_mfe.use_new_video_uploads_page` waffle flag is no longer respected. The code operates as if this is set to True.
a9724da to
3e590ec
Compare
|
Sandbox deployment failed 💥 |

The legacy video uploads page in Studio has been replaced with a new
view in the Authoring MFE. This change removes the now unused
JS/CSS/HTML/Python related to the old video page.
This work is part of #36108
BREAKING CHANGE: The
contentstore.new_studio_mfe.use_new_video_uploads_pagewaffle flag is no longer respected. The code operates as if this is set to True.