Skip to content

Conversation

@feanil
Copy link
Contributor

@feanil feanil commented Oct 30, 2025

The legacy video uploads page in Studio has been replaced with a new
view in the Authoring MFE. This change removes the now unused
JS/CSS/HTML/Python related to the old video page.

This work is part of #36108

BREAKING CHANGE: The contentstore.new_studio_mfe.use_new_video_uploads_page
waffle flag is no longer respected. The code operates as if this is set to True.

@feanil feanil force-pushed the feanil/drop_course_videos branch from fdd2b61 to 0e3689c Compare October 30, 2025 20:02
@feanil feanil changed the title feat: Drop support for the legacy video upload page. feat!: Drop support for the legacy video upload page. Oct 30, 2025
@feanil feanil force-pushed the feanil/drop_course_videos branch 4 times, most recently from fb7625b to d6dd652 Compare November 3, 2025 19:01
@feanil feanil force-pushed the feanil/drop_course_videos branch from d6dd652 to 58979c3 Compare January 8, 2026 19:54
@feanil feanil force-pushed the feanil/drop_course_videos branch from 58979c3 to a9724da Compare January 29, 2026 20:59
@feanil feanil marked this pull request as ready for review January 29, 2026 21:50
@feanil feanil requested a review from kdmccormick January 29, 2026 21:50
@feanil feanil added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Jan 29, 2026
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@kdmccormick
Copy link
Member

kdmccormick commented Jan 30, 2026

Wow, net -7000, nice 🔥

I didn't even realize there was a legacy video uploads page! Is it this? https://edx.readthedocs.io/projects/edx-partner-course-staff/en/latest/video/upload_video.html

Regarding the contentstore.new_studio_mfe.use_new_video_uploads_page--I think this is unfortunately a bit complicated. We had discussed in slack a while back: https://axim-collaborative.slack.com/archives/C03R320AFJP/p1740423161502069?thread_ts=1740064169.548659&cid=C03R320AFJP. Basically, the page requires edx-val, so it only works on edx.org or any other site which has managed to reverse-engineer the edX video pipeline enough to get uploads working (unclear to me if any such sites exist). With the waffle flag enabled, here's what Content > Videos looks like on the Ulmo sandbox:

Screenshot 2026-01-30 at 12 24 52 PM

I remember us discussing in standup (and hinted in that thread) that someone could maybe work on a version of the MFE page which didn't include any of the edX-specific stuff, and exposed plugin slots which edX could plug their stuff into. But I don't know what that would look like and I'm not sure who would do it. I think our options for the purpose of the legacy studio removal are either
(a) rip this new edX-specific MFE page out too now, or
(b) remove the legacy page right now, but leave the new page and its waffle flag in, punting that issue for a later time.

@feanil
Copy link
Contributor Author

feanil commented Jan 30, 2026

(b) remove the legacy page right now, but leave the new page and its waffle flag in, punting that issue for a later time.

You're saying keep the cleanup but leave the waffle flag in place so that the new MFE page remains off by default since it's actually useless for non edx.org operators at the moment? If we do that, we have to answer the question of what does the backend do when the waffle flag is set to false and there is no old page to display. I think this means we update the code to not provide links to the video page in this case and so we'll need to update other older templates to put conditional around those references. Does that sound right to you @kdmccormick ?

@kdmccormick
Copy link
Member

I think this means we update the code to not provide links to the video page in this case and so we'll need to update other older templates to put conditional around those references.

Good question, the thing is I'm not actually sure how one gets to the legacy video page, up until now I didn't know it even existed. Do you know how it's accessed today? Is it possible it's already behind some flag? If the new uploads page is fully edX-specific, then I'd guess that the legacy page is edX-specific too.

The legacy video uploads page in Studio has been replaced with a new
view in the Authoring MFE.  This change removes the now unused
JS/CSS/HTML/Python related to the old video page.

This work is part of #36108

BREAKING CHANGE: The `contentstore.new_studio_mfe.use_new_video_uploads_page`
waffle flag is no longer respected. The code operates as if this is set to True.
@feanil feanil force-pushed the feanil/drop_course_videos branch from a9724da to 3e590ec Compare January 30, 2026 20:49
@kdmccormick kdmccormick removed their request for review January 30, 2026 21:17
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants