Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove react-bootstrap dependency from Card component #2484

Closed
2 tasks
viktorrusakov opened this issue Jul 28, 2023 · 1 comment
Closed
2 tasks

Remove react-bootstrap dependency from Card component #2484

viktorrusakov opened this issue Jul 28, 2023 · 1 comment
Assignees
@PKulkoRaccoonGang
Labels
best addressed by breaking change code health Proactive technical investment via refactorings, removals, etc. engineering Engineering enhancement Relates to new features or improvements to existing features

Comments

@viktorrusakov
Copy link
Contributor

Currently Paragon inherits from react-bootstrap's Card which will become a problem after removing compound components (#2464) because their Card also has a multiple of compound components defined which will get into consuming applications' bundle without a single usage. Furthermore, we have completely customized Card's behaviour by building our own subcomponents, which resulted in not using anything from react-bootstrap besides Card wrapper. It doesn't make much sense anymore to re-use react-bootstrap's Card.

Tasks
Preview Give feedback
@viktorrusakov viktorrusakov added enhancement Relates to new features or improvements to existing features code health Proactive technical investment via refactorings, removals, etc. labels Jul 28, 2023
@viktorrusakov viktorrusakov mentioned this issue Jul 28, 2023
Open
@viktorrusakov viktorrusakov added the engineering Engineering label Jul 28, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Dec 4, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from Backlog to In progress in Paragon Working Group Dec 4, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this issue Dec 4, 2024
Merged
10 tasks
@brian-smith-tcril
Copy link
Contributor

resolved by #3318

@github-project-automation github-project-automation bot moved this from In progress to Done in Paragon Working Group Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PKulkoRaccoonGang PKulkoRaccoonGang

Labels
best addressed by breaking change code health Proactive technical investment via refactorings, removals, etc. engineering Engineering enhancement Relates to new features or improvements to existing features
Projects
Paragon Working Group
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@viktorrusakov @PKulkoRaccoonGang @brian-smith-tcril