Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required paginationLabel prop to TablePagination component's use of Pagination component. #3406

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

adamstankiewicz
Copy link
Member

Description

Original PR: #3393
(New PR created due to Netlify deploy preview issue blocking CI)

From @MichaelRoytman

This commit fixes a bug with the TablePagination component. This component renders the Pagination component without a paginationLabel prop, which is a required prop of the Pagination component. This commit adds a paginationLabel="table pagination"prop, which matches the prop passed to thePaginationComponentby theTablePaginationMinimal` component.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

… use of Pagination component

This commit fixes a bug with the TablePagination component. This component renders the Pagination component without a paginationLabel prop, which is a required prop of the Pagination component. This commit adds a paginationLabel="table pagination" prop, which matches the prop passed to the PaginationComponent by the TablePaginationMinimal component.
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for paragon-openedx-v22 ready!

Name Link
🔨 Latest commit 4376eb6
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx-v22/deploys/679d23321b57e000087c65d7
😎 Deploy Preview https://deploy-preview-3406--paragon-openedx-v22.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.40%. Comparing base (c0aa4c7) to head (4376eb6).
Report is 1 commits behind head on release-22.x.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-22.x    #3406   +/-   ##
=============================================
  Coverage         93.40%   93.40%           
=============================================
  Files               251      252    +1     
  Lines              4531     4534    +3     
  Branches           1066     1064    -2     
=============================================
+ Hits               4232     4235    +3     
  Misses              292      292           
  Partials              7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MichaelRoytman MichaelRoytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adamstankiewicz adamstankiewicz merged commit b0187dd into release-22.x Jan 31, 2025
10 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/pr-3393-reopen branch January 31, 2025 19:33
@openedx-semantic-release-bot

🎉 This PR is included in version 22.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants