chore: Remove remaining Python 3.8 compatibility #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
This wasn't being consistently used, and the changelog for releases has better informations.
Going to version 1 due to breaking changes in removing Python 3.8 functionality.
bmtcril
force-pushed
the
bmtcril/drop_py_38
branch
from
96782e0 to
82172e3
Compare
This command can be tricky, adding a link to a slightly better long-form resource. We should break up the readme into real docs with a lot more detail on some of these options.
|
Tested locally and here: openedx/tutor-contrib-aspects#1014 |
saraburns1
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in draft because I haven't done the manual testing steps yet.
Closes #81
Merge checklist:
Check off if complete or not applicable:
Manual testing:
openedx-dev-dockerfile-post-python-requirementsandopenedx-dockerfile-post-python-requirementsto use this branch for installingplatform-plugin-aspectseither using a local Tutor plugin or by making a temporary branch in the Aspects plugintutor config savetutor images build openedxtutor local stoptutor local do init -l aspectstutor local start -dtutor local do dump_data_to_clickhouse --service cms --object course_overviews --options "--force"and make sure that the data correctly moves to Clickhouse by monitoring the cms-worker and checking Clickhouse for new entries inevent_sink.course_blocks