Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to embed translated dashboard #24

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Apr 5, 2024

Description

This PR allows the embedding of translated dashboards.

Test against: openedx/tutor-contrib-aspects#697

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 5, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 requested review from pomegranited and bmtcril April 5, 2024 21:12
@Ian2012 Ian2012 force-pushed the cag/translate-dashboard branch 3 times, most recently from 65aadf7 to 6b37885 Compare April 8, 2024 14:11
Copy link

github-actions bot commented Apr 8, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  platform_plugin_aspects
  __init__.py
  utils.py
  platform_plugin_aspects/extensions
  filters.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just once comment for consistency otherwise LGTM

platform_plugin_aspects/extensions/filters.py Outdated Show resolved Hide resolved
@Ian2012 Ian2012 force-pushed the cag/translate-dashboard branch from a8d50e8 to 6a5d53d Compare April 9, 2024 15:42
Ian2012 added 2 commits April 9, 2024 10:44
fix: allow to translate Analytics tab title

test: fix tests
@Ian2012 Ian2012 force-pushed the cag/translate-dashboard branch from 6a5d53d to 0ab1bc9 Compare April 9, 2024 15:44
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ian2012 Ian2012 merged commit da0bb9c into main Apr 9, 2024
7 checks passed
@Ian2012 Ian2012 deleted the cag/translate-dashboard branch April 9, 2024 16:28
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants