Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Performance testing script updates #1006

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix: Performance testing script updates #1006

merged 3 commits into from
Dec 19, 2024

Conversation

saraburns1
Copy link
Contributor

  1. Add check to compare count of slices to rowcount from clickhouse to ensure data for all slices has been returned
  2. Add 'strip' to remove whitespace that caused memory=none issues
  3. Simplify ch query

@saraburns1 saraburns1 requested a review from bmtcril December 18, 2024 19:34
@saraburns1 saraburns1 changed the title fix: fix memory=none and clickhouse query fix: Performance testing script updates Dec 18, 2024
bmtcril
bmtcril approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits 👍

tutoraspects/templates/aspects/apps/superset/pythonpath/performance_metrics.py Outdated Show resolved Hide resolved
...pects/templates/aspects/build/aspects-superset/openedx-assets/assets/datasets/query_log.yaml Outdated Show resolved Hide resolved
@bmtcril
Copy link
Contributor

bmtcril commented Dec 19, 2024

Any idea why the SQL is empty?

40. learner-groups - Enrollees by Enrollment Track f8beeb8c-b35c-47fc-8370-96b493f9c1b8
Superset time: 0.13573 (s).
Query duration: 0.012 (s).
Result rows: 3
Memory Usage (MB): 4.420504570007324
Row count (superset) 3
Filters: []
SQL:

@saraburns1
Copy link
Contributor Author

you have to specify the option to print the sql

"--print_sql", is_flag=True, default=False, help="Whether to print the SQL run."

@saraburns1 saraburns1 merged commit 3600c2b into openedx:main Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmtcril bmtcril bmtcril approved these changes

@Ian2012 Ian2012 Ian2012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saraburns1 @bmtcril @Ian2012