-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add forum interaction tab (FC-0033) #458
Conversation
This change adds a forum interaction tab to the instructor dashboard and includes two new charts: the number of active forum users and the number of posts per user.
Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
time_range: No filter | ||
viz_type: big_number_total | ||
y_axis_format: SMART_NUMBER | ||
query_context: '{"datasource": {"id": 57, "type": "table"}, "force": false, "queries": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these query_context
s? The size of the assets is big enough that it might push us over the limit in k8s again, so anything we can do to keep these smaller is helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a clean step in the serialize command to automatically remove not needed assets fields
@SoryRawyer Welcome back. Nice work, as always! |
@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This change adds a forum interaction tab to the instructor dashboard and includes two new charts: the number of active forum users and the number of posts per user.
Here is a screenshot of the new tab: