Skip to content

fix: Quote new templated values in assets #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: Quote new templated values in assets #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/test-tutor-aspects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ jobs:
- name: Import demo course
run: tutor local do importdemocourse
- name: Test commands
run: tutor local do dump-courses-to-clickhouse --options "--force"
run: |
tutor local do dump-courses-to-clickhouse --options "--force"
make extract_translations
- name: Tutor stop
run: tutor local stop

Expand Down
2 changes: 1 addition & 1 deletion ...tes/aspects/build/aspects-superset/openedx-assets/assets/databases/Superset_Metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
_file_name: Superset_Metadata.yaml
database_name: Superset Metadata
sqlalchemy_uri: {{SUPERSET_METADATA_SQLALCHEMY_URI}}
sqlalchemy_uri: "{{SUPERSET_METADATA_SQLALCHEMY_URI}}"
cache_timeout: 86400
expose_in_sqllab: true
allow_run_async: false
Expand Down
2 changes: 1 addition & 1 deletion ...ts/build/aspects-superset/openedx-assets/assets/datasets/monitoring.superset_ab_user.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: null
default_endpoint: null
offset: 0
cache_timeout: null
schema: {{SUPERSET_DB_METADATA_NAME}}
schema: "{{SUPERSET_DB_METADATA_NAME}}"
sql: null
params: null
template_params: null
Expand Down
2 changes: 1 addition & 1 deletion ...build/aspects-superset/openedx-assets/assets/datasets/monitoring.superset_action_log.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: null
default_endpoint: null
offset: 0
cache_timeout: null
schema: {{SUPERSET_DB_METADATA_NAME}}
schema: "{{SUPERSET_DB_METADATA_NAME}}"
sql: "select\nl.dttm as action_date,\ncase \n when lower(l.action)\
\ = 'queries' then 'query from sqllab'\n when lower(l.action) = 'chartrestapi.data'\
\ then 'query from charts'\n when lower(l.action) = 'count' then 'dashboard view'\n\
Expand Down
2 changes: 1 addition & 1 deletion .../build/aspects-superset/openedx-assets/assets/datasets/monitoring.superset_dashboard.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: null
default_endpoint: null
offset: 0
cache_timeout: null
schema: {{SUPERSET_DB_METADATA_NAME}}
schema: "{{SUPERSET_DB_METADATA_NAME}}"
sql: null
params: null
template_params: null
Expand Down
2 changes: 1 addition & 1 deletion ...cts/build/aspects-superset/openedx-assets/assets/datasets/monitoring.superset_slices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: null
default_endpoint: null
offset: 0
cache_timeout: null
schema: {{SUPERSET_DB_METADATA_NAME}}
schema: "{{SUPERSET_DB_METADATA_NAME}}"
sql: null
params: null
template_params: null
Expand Down
2 changes: 1 addition & 1 deletion ...cts/build/aspects-superset/openedx-assets/assets/datasets/monitoring.superset_tables.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: null
default_endpoint: null
offset: 0
cache_timeout: null
schema: {{SUPERSET_DB_METADATA_NAME}}
schema: "{{SUPERSET_DB_METADATA_NAME}}"
sql: null
params: null
template_params: null
Expand Down