Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to clickhouse 24.3 LTS #685

Merged
merged 1 commit into from
Apr 2, 2024
Merged

feat: upgrade to clickhouse 24.3 LTS #685

merged 1 commit into from
Apr 2, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Apr 1, 2024

Description

This PR upgrades the ClickHouse version to 24.3. As the new query analyzer is enabled by default, it will try to parse every query and will fail to do so when there is a nested with using the same name, so SQL queries are updated with the prefix base.

Depends on: openedx/aspects-dbt#59

@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 1, 2024
@Ian2012 Ian2012 requested review from SoryRawyer and bmtcril April 1, 2024 16:11
@Ian2012 Ian2012 force-pushed the cag/clickhouse-24.3 branch from 68a0c1f to 898aece Compare April 1, 2024 18:45
@Ian2012 Ian2012 force-pushed the cag/clickhouse-24.3 branch from 898aece to 2542a5a Compare April 1, 2024 20:06
@Ian2012 Ian2012 merged commit 6c751ad into main Apr 2, 2024
9 checks passed
@Ian2012 Ian2012 deleted the cag/clickhouse-24.3 branch April 2, 2024 15:27
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants