Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate aspects dictionaries to dbt #690

Merged
merged 7 commits into from
Apr 16, 2024
Merged

feat: migrate aspects dictionaries to dbt #690

merged 7 commits into from
Apr 16, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Apr 2, 2024

Description

This PR drops all dictionaries, related tables, and MVs in favor of DBT dictionary definitions.

Depends on: openedx/aspects-dbt#60

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 2, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 2, 2024

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 force-pushed the cag/dictionaries branch 4 times, most recently from bb872d1 to 0b56a57 Compare April 8, 2024 15:52
@Ian2012 Ian2012 marked this pull request as ready for review April 8, 2024 15:52
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Apr 12, 2024
feat: migrate aspects dictionaries to dbt
@Ian2012 Ian2012 requested a review from bmtcril April 15, 2024 17:54
tutoraspects/plugin.py Outdated Show resolved Hide resolved
@Ian2012 Ian2012 merged commit 8dc8b53 into main Apr 16, 2024
9 checks passed
@Ian2012 Ian2012 deleted the cag/dictionaries branch April 16, 2024 18:47
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants