Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to superset v4.0.0 #693

Merged
merged 11 commits into from
Apr 9, 2024
Merged

feat: migrate to superset v4.0.0 #693

merged 11 commits into from
Apr 9, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Apr 4, 2024 •
edited
Loading

Description

This PR upgrades the superset version to v4.0.0.
This PR also:

  • Automatically refresh datasets on import which will load the most recent columns (and remove old ones) on datasets
  • fixes an issue with the from_dttm SQL template

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 4, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 requested a review from bmtcril April 5, 2024 14:51
@Ian2012 Ian2012 changed the title feat: migrate to superset v3.1.2 feat: migrate to superset v4.0.0 Apr 8, 2024
bmtcril
bmtcril reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just once comment, and can you re-update the PR description?

tutoraspects/plugin.py Show resolved Hide resolved
bmtcril
bmtcril approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Ian2012 Ian2012 merged commit 167ad65 into main Apr 9, 2024
9 checks passed
@Ian2012 Ian2012 deleted the cag/superset4.0 branch April 9, 2024 16:44
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Ian2012 Ian2012 mentioned this pull request Apr 10, 2024
Closed
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmtcril bmtcril bmtcril approved these changes

Assignees
No one assigned
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ian2012 @openedx-webhooks @bmtcril @itsjeyd