Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator Dashboard Enhancements #745

Merged
merged 17 commits into from
Apr 29, 2024
Merged

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Apr 23, 2024

This PR includes a number of bug fixes and enhancements, you may want to review by commit.

Requires openedx/aspects-dbt#74 to merge and release before this can be merged.

@@ -334,7 +334,7 @@
# For now we are pulling this from github, which should allow maximum
# flexibility for forking, running branches, specific versions, etc.
("DBT_REPOSITORY", "https://github.com/openedx/aspects-dbt"),
("DBT_BRANCH", "v3.19.0"),
("DBT_BRANCH", "bmtcril/operator_dash_enhancements"),
Copy link
Contributor Author

@bmtcril bmtcril Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated once the latest aspects-dbt is released

@bmtcril bmtcril force-pushed the bmtcril/operator_dash_enhancements branch from 59cbdda to 321b2c4 Compare April 24, 2024 20:11
@bmtcril bmtcril marked this pull request as ready for review April 24, 2024 20:12
@bmtcril bmtcril changed the title Bmtcril/operator dash enhancements Operator Dashboard Enhancements Apr 24, 2024
Copy link
Contributor

@Ian2012 Ian2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally

@SoryRawyer
Copy link
Contributor

I'm still waiting for tutor init to finish so I can confirm that the change from fact_instance_activity to fact_instance_actors works as expected, but otherwise the dashboard changes look good 👍🏻

Copy link
Contributor

@SoryRawyer SoryRawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@bmtcril bmtcril merged commit b68a545 into main Apr 29, 2024
9 checks passed
@bmtcril bmtcril deleted the bmtcril/operator_dash_enhancements branch April 29, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants