Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import latest version of course dashboard #771

Merged
merged 6 commits into from
May 7, 2024
Merged

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented May 6, 2024

Description

This PR import the latest version of the course dashboard.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 requested review from bmtcril and SoryRawyer May 6, 2024 19:58
@Ian2012 Ian2012 force-pushed the cag/course-dashboard branch 4 times, most recently from 6ca14d3 to 629f0de Compare May 6, 2024 22:18
@Ian2012 Ian2012 force-pushed the cag/course-dashboard branch from 629f0de to 69d6034 Compare May 6, 2024 23:20
@bmtcril
Copy link
Contributor

bmtcril commented May 7, 2024

Just a couple of questions. Since the chart diffs are always a mess, I can't tell what all is fixed in here. Does this have the string truncation or other fixes we've talked about?

@Ian2012
Copy link
Contributor Author

Ian2012 commented May 7, 2024

@bmtcril No, I want to first import the Course Dashboard and then:

  • Work on string translations (mark strings as translatable)
  • Work on translatable columns
  • Truncate the strings
  • Whatever needs to be done to finish the course dashboard

tutoraspects/plugin.py Outdated Show resolved Hide resolved
@Ian2012 Ian2012 merged commit cb1d0bc into main May 7, 2024
9 checks passed
@Ian2012 Ian2012 deleted the cag/course-dashboard branch May 7, 2024 18:51
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants