At-risk dashboard performance enhancements #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmtcril
commented
May 22, 2024
| @@ -15,6 +15,7 @@ EVENT_SINK_CLICKHOUSE_PII_MODELS = {{ EVENT_SINK_PII_MODELS }} | |||
|
|
|||
| ASPECTS_INSTRUCTOR_DASHBOARDS = {{ ASPECTS_INSTRUCTOR_DASHBOARDS }} | |||
| SUPERSET_DASHBOARD_LOCALES = {{ SUPERSET_DASHBOARD_LOCALES }} | |||
| SUPERSET_SHOW_INSTRUCTOR_DASHBOARD_LINK = {{ SUPERSET_SHOW_INSTRUCTOR_DASHBOARD_LINK }} | |||
There was a problem hiding this comment.
Needed for platform-plugin-aspects 0.9.4
bmtcril
commented
May 22, 2024
Ian2012
reviewed
May 22, 2024
Ian2012
reviewed
May 22, 2024
.../templates/aspects/build/aspects-superset/openedx-assets/assets/charts/At-risk_learners.yaml
Show resolved
Hide resolved
...plates/aspects/build/aspects-superset/openedx-assets/assets/dashboards/At-Risk_Learners.yaml
Show resolved
Hide resolved
tutoraspects/templates/openedx-assets/queries/at_risk_learner_filter.sql
Outdated
Show resolved
Hide resolved
Comment on lines
2
to
9
| page_visits as ( | ||
| select org, course_key, actor_id, max(last_visited) as last_visited | ||
| from {{ ASPECTS_XAPI_DATABASE }}.fact_learner_last_course_visit | ||
| where | ||
| 1=1 | ||
| {% include 'openedx-assets/queries/common_filters.sql' %} | ||
| group by org, course_key, actor_id | ||
| ) |
There was a problem hiding this comment.
Same as above, usually the MV with org/course_key partition is good enough to improve the query times
There was a problem hiding this comment.
It definitely improves query times, but this does so even more. IIRC the MV took the query I was testing from running out of memory to about 12 seconds, this brought it down closer to 6.
|
@bmtcril rerunning CI checks with the emission time changes: https://github.com/openedx/tutor-contrib-aspects/actions/runs/9195812496/job/25292445072?pr=822 |
SoryRawyer
reviewed
May 22, 2024
|
Closing/reopening to re run tests with latest dbt changes |
This was referenced May 22, 2024
Ian2012
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance of the various charts of the at-risk dashboard. In the 300M row dataset all charts load now, though some are still slow. The problem engagement charts should be able to be improved by other changes in flight.
This also bumps platform-plugin-aspects to 0.9.4 and adds its new setting
Closes: #793
Closes: #792