fix: Import of custom Superset assets #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pomegranited you'll need this fix to use custom assets. My tests for this are here: https://github.com/bmtcril/tutor-contrib-aspects-extension |
bmtcril
added a commit
to bmtcril/tutor-contrib-aspects-extension
that referenced
this pull request
Jun 21, 2024
This requires openedx/tutor-contrib-aspects#881 to be merged to work.
Ian2012
approved these changes
Jun 21, 2024
Previously the commands and helpers that we use to ensure various things import correctly only worked for Aspects itself. However extension developers will need to do this for their assets as well, so this lets us choose where to write the processed assets to.
bmtcril
force-pushed
the
bmtcril/fix_custom_assets
branch
from
092983c to
fd44ff4
Compare
|
@Ian2012 this could use a re-review whenever you have a min. |
Ian2012
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom Superset assets are all pushed into a single assets.yaml file, and need to be separated by
---lines. This fixes the ability to read multiple custom assets from the assets.yaml /superset-extra-assetspatch.Also allows the
import_superset_zipcommand to serialize assets to other locations so that extensions can use it as well.