Feature/821 bb rest 3lo try2 #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyIsConfused
suggested changes
Jun 16, 2020
There was a problem hiding this comment.
Some blackboard specific code has been copied from D2L with all the references to D2L remaining.
I'd suggest either: Reword all the comments and identifiers, or refactor out the common code into its own area and have both D2L and Bb code refer to it to reduce duplication.
.../Core/com.equella.core/src/com/tle/core/connectors/blackboard/BlackboardRestUserContext.java
Outdated
Show resolved
Hide resolved
Source/Plugins/Core/com.equella.core/src/com/tle/core/auditlog/AuditLogService.java
Outdated
Show resolved
Hide resolved
...om.equella.core/src/com/tle/core/connectors/blackboard/BlackboardRESTConnectorConstants.java
Outdated
Show resolved
Hide resolved
...s/Core/com.equella.core/src/com/tle/core/connectors/blackboard/BlackboardRestAppContext.java
Outdated
Show resolved
Hide resolved
.../Core/com.equella.core/src/com/tle/core/connectors/blackboard/BlackboardRestUserContext.java
Outdated
Show resolved
Hide resolved
.../Core/com.equella.core/src/com/tle/core/connectors/blackboard/BlackboardRestUserContext.java
Outdated
Show resolved
Hide resolved
.../Core/com.equella.core/src/com/tle/core/connectors/blackboard/BlackboardRestUserContext.java
Outdated
Show resolved
Hide resolved
.../Core/com.equella.core/src/com/tle/core/connectors/blackboard/BlackboardRestUserContext.java
Outdated
Show resolved
Hide resolved
...lugins/Core/com.equella.core/src/com/tle/core/connectors/blackboard/beans/ErrorResponse.java
Outdated
Show resolved
Hide resolved
.../src/com/tle/core/connectors/blackboard/service/impl/BlackboardRESTConnectorServiceImpl.java
Outdated
Show resolved
Hide resolved
Source/Plugins/Core/com.equella.core/src/com/tle/web/connectors/dialog/LMSAuthDialog.java
Outdated
Show resolved
Hide resolved
Source/Plugins/Core/com.equella.core/resources/view/dialog/lmsauth.ftl
Outdated
Show resolved
Hide resolved
...lla.core/src/com/tle/web/connectors/blackboard/servlet/BlackboardRestOauthSignonServlet.java
Outdated
Show resolved
Hide resolved
cbeach47
added a commit
that referenced
this pull request
Jun 25, 2020
cbeach47
added a commit
that referenced
this pull request
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old PR: #1752
Checklist
Description of change
Blackboard REST MVP ( looking to keep the number of commits into Dev small since I'll likely need to backport this into 2019.1 / 2019.2 / 2020.0 ) ( https://github.com/openequella/openEQUELLA/issues?q=is%3Aopen+label%3A%22Integration+-+Bb+LTI%2FREST%22+milestone%3A2020.2 ):
Included: