Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/821 bb rest 3lo try2 #1781

Merged
merged 10 commits into from
Jun 23, 2020

Conversation

cbeach47
Copy link
Contributor

@cbeach47 cbeach47 commented Jun 2, 2020

Old PR: #1752

Checklist

Description of change

Blackboard REST MVP ( looking to keep the number of commits into Dev small since I'll likely need to backport this into 2019.1 / 2019.2 / 2020.0 ) ( https://github.com/openequella/openEQUELLA/issues?q=is%3Aopen+label%3A%22Integration+-+Bb+LTI%2FREST%22+milestone%3A2020.2 ):

Included:

@cbeach47 cbeach47 requested a review from a team June 2, 2020 17:15
Copy link
Contributor

@SammyIsConfused SammyIsConfused left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some blackboard specific code has been copied from D2L with all the references to D2L remaining.
I'd suggest either: Reword all the comments and identifiers, or refactor out the common code into its own area and have both D2L and Bb code refer to it to reduce duplication.

Copy link
Contributor

@PenghaiZhang PenghaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general feedback.

Copy link
Contributor

@PenghaiZhang PenghaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbeach47 cbeach47 merged commit 17902b8 into openequella:develop Jun 23, 2020
@cbeach47 cbeach47 deleted the feature/821-bb-rest-3lo-try2 branch June 23, 2020 20:50
cbeach47 added a commit that referenced this pull request Jun 25, 2020
* #821 MVP code for 3LO auth

* Three legged authentication for Blackboard. (Incomplete)

* #819 - Courses now cache

Co-authored-by: Diego del Blanco <ddelblanco@unicon.net>
cbeach47 added a commit that referenced this pull request Jun 25, 2020
* #821 MVP code for 3LO auth

* Three legged authentication for Blackboard. (Incomplete)

* #819 - Courses now cache

Co-authored-by: Diego del Blanco <ddelblanco@unicon.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants