Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install guide #39

Merged
merged 5 commits into from
Mar 30, 2020
Merged

Install guide #39

merged 5 commits into from
Mar 30, 2020

Conversation

mrblippy
Copy link
Contributor

@mrblippy mrblippy commented Jan 4, 2019

Issues #21 and #28

Copy link
Member

@edalex-ian edalex-ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrblippy

Love the changes to the install guide, that definitely is an improvement. Maybe at the end should we also add, for further information, see the Full Installation Guide - InstallationAdminGuide.md.

gettingstarted/InstallingEquella.md Outdated Show resolved Hide resolved
gettingstarted/InstallingEquella.md Outdated Show resolved Hide resolved
gettingstarted/InstallingEquella.md Show resolved Hide resolved
guides/MoodleIntegrationGuide.md Outdated Show resolved Hide resolved
guides/MoodleIntegrationGuide.md Outdated Show resolved Hide resolved
@edalex-ian
Copy link
Member

edalex-ian commented Jan 9, 2019

Cool, just that comment about the backticks left. ;)

Oh, and a link off to the full install guide.

Copy link
Contributor

@cbeach47 cbeach47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes.

To make it more friendly for new adopters of openEQUELLA, we should also add latest known versions of the supporting applications to increase the likelihood of initial install success.

gettingstarted/InstallingEquella.md Outdated Show resolved Hide resolved
gettingstarted/InstallingEquella.md Show resolved Hide resolved
gettingstarted/InstallingEquella.md Outdated Show resolved Hide resolved
gettingstarted/InstallingEquella.md Outdated Show resolved Hide resolved
gettingstarted/InstallingEquella.md Show resolved Hide resolved
@edalex-ian
Copy link
Member

@cbeach47 : Should we consider adding a new page which shows a supported versions matrix for the various dependencies? That way we have it in one place and it can be referenced both here and in the full install guide.

@cbeach47
Copy link
Contributor

@mrblippy - thanks for adding those versions in. We should include a blurb about Ghostscript being needed for PDF thumbnails.

@edalex-ian - yes, I think it would provide solid value-add to have a supported versions page and link the various guides to it.

@cbeach47
Copy link
Contributor

cbeach47 commented Apr 9, 2019

Hi @mrblippy - Any concerns with the suggested changes to make? It'd be nice to get this pushed over the finish line.

@edalex-ian
Copy link
Member

Ah drats! Sorry @mrblippy looks like my #61 clashed with some of this. I didn't realise there was an issue already raised let alone this PR addressing it.

Anyway, still be great to get your other bits in.

Copy link
Member

@edalex-ian edalex-ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this ticked off, and if further updates are needed let's get a new PR going.

@edalex-ian edalex-ian merged commit e71e25e into master Mar 30, 2020
@edalex-ian edalex-ian deleted the InstallGuide branch March 30, 2020 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants